chore(cdk greenfield support): Changes to support greenfield account restrictions present in higher environments #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… greenfield accounts
|
also note, the clamscan dependency at the top level can probably be removed. thats unrelated but i noticed it |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
asharonbaltazar
approved these changes
Aug 2, 2024
mdial89f
temporarily deployed
to
greenfield-kibana
GitHub Actions
Inactive
asharonbaltazar
approved these changes
Aug 2, 2024
|
Code Climate has analyzed commit c89a0d8 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 0.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 52.4% (-0.1% change). View more on Code Climate. |
|
|
||
| public visit(node: IConstruct): void { | ||
| if (node instanceof iam.Role && isCfnRole(node.node.defaultChild)) { | ||
| node.node.defaultChild?.addPropertyOverride("Path", this.iamPath); |
There was a problem hiding this comment.
Just noticed this ?. The other ones don't have it so I'm assuming you forgot this one?
|
🎉 This PR is included in version 1.5.0-val.69 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In higher environments, iam path and permissions boundary is enforced on our users and service roles. This required modifying the cdk tool kit bootstrapping process, as well as adding config to our application.
Linked Issues to Close
None
Approach
The CDK is bootstrapped with a template that accounts for iam path and permissions boundary. The roles generated are then passed in the synthesizer config. Finally, two cdk aspects ensure all iam objects built by our application have the path and permissionsboundary set.
Assorted Notes/Considerations/Learning
A procedure on bootstrapping cdk is warranted, and will come along a bit later.