Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High level adjustments of structure and import pattern, also new email stack #688

Merged
merged 24 commits into from
Jul 29, 2024

Conversation

benjaminpaige
Copy link
Collaborator

This moves the stacks into a stack dir (im not sure why some say new and others moved, i thought i mv'ed all of them) but. also it adjust the email stack a bit and cleans up a lot of the imports. But i don't want to merge it until the deploy is functioning as expected. I just wanted you to get eyes on it.

@benjaminpaige benjaminpaige requested a review from mdial89f July 28, 2024 18:44
Copy link
Contributor

github-actions bot commented Jul 28, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 51.11% 3886 / 7603
🔵 Statements 51% 4100 / 8038
🔵 Functions 44.44% 901 / 2027
🔵 Branches 25.83% 761 / 2946
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
lib/lambda/processEmails.ts 0% 0% 0% 0% 5-6, 9-22, 14-22, 25-34, 26-33, 36-99, 40, 42-44, 43, 46, 48-86, 50-84, 51-59, 61-62, 64, 66-70, 72-81, 83, 88-94, 89-93, 90, 92, 96-97
lib/local-constructs/manage-users/index.test.ts 100% 100% 100% 100%
lib/local-constructs/manage-users/src/manageUsers.test.ts 100% 100% 100% 100%
lib/packages/shared-utils/decode.test.ts 100% 100% 100% 100%
lib/packages/shared-utils/secrets-manager.test.ts 100% 100% 100% 100%
lib/stacks/auth.ts 0% 0% 0% 0% 36-41, 50, 64-69, 72-99, 102-130, 104-129, 133-163, 165-172, 175-188, 191-217, 219-226, 228-239, 241-319, 242-249, 251-313, 315-318, 321
lib/stacks/data.ts 0% 0% 0% 0% 31-34, 55-56, 62, 64-332, 65-66, 68-75, 77-86, 88-95, 97-109, 111-129, 131-137, 139-146, 148-160, 162-169, 171-182, 184-192, 194-241, 238, 243-254, 256-310, 312-318, 320-328, 330-331, 334-344, 346-354, 347-353, 356-411, 375-397, 399-408, 400, 403-407, 410, 413-462, 464-472, 474-491, 476-488, 493-515, 517-545, 547-555, 548-568, 570-615, 617-769, 626, 678, 737, 771-778, 780-793, 795-802, 804-846, 848-854, 856-865, 867-869, 868, 872-914, 893, 916-924, 926
lib/stacks/email.ts 0% 100% 0% 0% 27, 44, 47-68, 71-74, 77-86, 89-92, 95-110, 114-136, 138, 141-174, 177-204, 207, 211-232, 221-224, 235-242
lib/stacks/networking.ts 0% 100% 0% 0% 16-17, 23-24, 26-34, 36, 38
react-app/src/components/RHF/Field.tsx 100% 80% 100% 100%
react-app/src/components/RHF/FormGroup.tsx 100% 100% 100% 100%
react-app/src/components/RHF/SlotField.tsx 86.66% 68.75% 75% 92.3% 93-95, 189
react-app/src/components/RHF/tests/additionalRules.test.ts 94.44% 50% 100% 100% 42, 72, 103
react-app/src/components/RHF/utils/additionalRules.ts 87.09% 93.75% 71.42% 86.66% 7-8, 39, 69
Generated in workflow #13

Copy link
Contributor

@mdial89f mdial89f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

i like the changes, especially import *. lets gooooo

@benjaminpaige benjaminpaige changed the title High level adjustments of structure and import pattern, also new email stack -wip High level adjustments of structure and import pattern, also new email stack Jul 29, 2024
Copy link
Contributor

github-actions bot commented Aug 5, 2024

🎉 This PR is included in version 1.5.0-val.69 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants