Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test): tests for Dashboard #1094

Merged
merged 23 commits into from
Feb 4, 2025
Merged

feat(test): tests for Dashboard #1094

merged 23 commits into from
Feb 4, 2025

Conversation

thetif
Copy link
Collaborator

@thetif thetif commented Jan 30, 2025

💬 Description / Notes

Test coverage for Dashboard components

🛠 Changes

  • added tests for dashboard components
  • added test helpers
  • converted column hooks to wait for user to be fetched before returning columns

Copy link
Contributor

github-actions bot commented Jan 30, 2025

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 91.65% (🎯 90%)
⬆️ +2.09%
4394 / 4794
🟢 Statements 91.16% (🎯 90%)
⬆️ +2.22%
4785 / 5249
🟢 Functions 85.81% (🎯 85%)
⬆️ +4.04%
1331 / 1551
🟢 Branches 80.12% (🎯 80%)
⬆️ +4.33%
2294 / 2863
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
react-app/src/api/useGetUser.ts 100%
🟰 ±0%
91.66%
🟰 ±0%
100%
🟰 ±0%
100%
🟰 ±0%
react-app/src/components/Opensearch/main/Filtering/index.tsx 100%
🟰 ±0%
100%
🟰 ±0%
100%
🟰 ±0%
100%
🟰 ±0%
react-app/src/components/Opensearch/main/Filtering/Chipbar/index.tsx 95.12%
🟰 ±0%
92.59%
🟰 ±0%
93.75%
🟰 ±0%
100%
🟰 ±0%
35, 81
react-app/src/components/Pagination/index.tsx 100%
🟰 ±0%
100%
🟰 ±0%
100%
🟰 ±0%
100%
🟰 ±0%
react-app/src/features/dashboard/Lists/renderCells/index.tsx 100%
⬆️ +75.00%
100%
⬆️ +100.00%
100%
⬆️ +100.00%
100%
⬆️ +70.00%
react-app/src/features/dashboard/Lists/spas/consts.tsx 100%
⬆️ +97.23%
100%
⬆️ +100.00%
100%
⬆️ +100.00%
100%
⬆️ +96.97%
react-app/src/features/dashboard/Lists/spas/index.tsx 100%
⬆️ +66.67%
100%
🟰 ±0%
100%
⬆️ +100.00%
100%
⬆️ +66.67%
react-app/src/features/dashboard/Lists/waivers/consts.tsx 100%
⬆️ +97.50%
92.15%
⬆️ +92.15%
100%
⬆️ +100.00%
100%
⬆️ +97.23%
react-app/src/features/dashboard/Lists/waivers/index.tsx 100%
⬆️ +66.67%
100%
🟰 ±0%
100%
⬆️ +100.00%
100%
⬆️ +66.67%
Generated in workflow #1929 for commit 320c484 by the Vitest Coverage Report Action

@thetif thetif temporarily deployed to test-dashboard-app January 31, 2025 22:03 — with GitHub Actions Inactive
@thetif thetif temporarily deployed to test-dashboard-kibana January 31, 2025 22:03 — with GitHub Actions Inactive
@thetif thetif temporarily deployed to test-dashboard-app January 31, 2025 22:21 — with GitHub Actions Inactive
@thetif thetif requested a review from thwalker6 February 4, 2025 15:14
@thetif thetif marked this pull request as ready for review February 4, 2025 15:14
@thetif thetif temporarily deployed to test-dashboard-kibana February 4, 2025 15:17 — with GitHub Actions Inactive
@thetif thetif temporarily deployed to test-dashboard-app February 4, 2025 15:17 — with GitHub Actions Inactive
Copy link
Collaborator

@thwalker6 thwalker6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thetif thetif merged commit 30b8016 into main Feb 4, 2025
17 checks passed
@thetif thetif deleted the test-dashboard branch February 4, 2025 15:35
Copy link
Contributor

github-actions bot commented Feb 4, 2025

🎉 This PR is included in version 1.5.0-val.123 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants