Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): Fix chip pdf links issue on FAQ page #1080

Merged
merged 6 commits into from
Jan 31, 2025
Merged

fix(ui): Fix chip pdf links issue on FAQ page #1080

merged 6 commits into from
Jan 31, 2025

Conversation

tbolt
Copy link
Collaborator

@tbolt tbolt commented Jan 28, 2025 •
edited
Loading

🎫 Linked Ticket

Ticket to close

💬 Description / Notes

Fixes URL for CHIP links on FAQ page

🛠 Changes

added /chp to broken FAQ page PDF links

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 89.04% 4249 / 4772
🔵 Statements 88.46% 4626 / 5229
🔵 Functions 81.77% 1265 / 1547
🔵 Branches 75.13% 2139 / 2847
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
react-app/src/features/faq/content/chpTemplates.ts 100% 100% 100% 100%
Generated in workflow #1856 for commit c428cf3 by the Vitest Coverage Report Action

@tbolt tbolt temporarily deployed to chip-pdf-links January 28, 2025 18:25 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to chip-pdf-links January 28, 2025 18:25 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to chip-pdf-links-kibana January 28, 2025 18:25 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to chip-pdf-links-app January 28, 2025 18:25 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to chip-pdf-links January 28, 2025 18:25 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to chip-pdf-links January 28, 2025 18:43 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to chip-pdf-links January 28, 2025 18:43 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to chip-pdf-links January 28, 2025 18:45 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to chip-pdf-links January 28, 2025 18:45 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to chip-pdf-links-app January 28, 2025 18:45 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to chip-pdf-links-kibana January 28, 2025 18:45 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to chip-pdf-links January 28, 2025 18:45 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to chip-pdf-links January 29, 2025 18:05 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to chip-pdf-links January 29, 2025 18:05 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to chip-pdf-links January 29, 2025 18:09 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to chip-pdf-links-kibana January 29, 2025 18:09 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to chip-pdf-links January 29, 2025 18:09 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to chip-pdf-links-app January 29, 2025 18:09 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to chip-pdf-links January 29, 2025 18:09 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to chip-pdf-links January 30, 2025 17:57 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to chip-pdf-links January 30, 2025 17:57 — with GitHub Actions Inactive
@tbolt tbolt requested a review from rmuntaqim January 30, 2025 17:59
@tbolt tbolt marked this pull request as ready for review January 30, 2025 17:59
@tbolt tbolt self-assigned this Jan 30, 2025
@tbolt tbolt temporarily deployed to chip-pdf-links January 30, 2025 18:01 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to chip-pdf-links-kibana January 30, 2025 18:01 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to chip-pdf-links-app January 30, 2025 18:01 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to chip-pdf-links January 30, 2025 18:01 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to chip-pdf-links January 30, 2025 18:01 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to chip-pdf-links January 31, 2025 14:46 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to chip-pdf-links January 31, 2025 14:46 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to chip-pdf-links January 31, 2025 14:48 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to chip-pdf-links-kibana January 31, 2025 14:48 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to chip-pdf-links-app January 31, 2025 14:48 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to chip-pdf-links January 31, 2025 14:48 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to chip-pdf-links January 31, 2025 14:48 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to chip-pdf-links January 31, 2025 19:24 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to chip-pdf-links January 31, 2025 19:24 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to chip-pdf-links January 31, 2025 19:29 — with GitHub Actions Inactive
@tbolt tbolt deployed to chip-pdf-links January 31, 2025 19:29 — with GitHub Actions Active
@tbolt tbolt temporarily deployed to chip-pdf-links January 31, 2025 19:29 — with GitHub Actions Inactive
@tbolt tbolt merged commit ec52d2c into main Jan 31, 2025
15 checks passed
@tbolt tbolt deleted the chip-pdf-links branch January 31, 2025 19:32
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

🎉 This PR is included in version 1.5.0-val.121 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

rmuntaqim pushed a commit that referenced this pull request Feb 4, 2025
@tbolt @rmuntaqim
fix(ui): Fix chip pdf links issue on FAQ page (#1080)
7f0ea8a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asharonbaltazar asharonbaltazar asharonbaltazar approved these changes

@charmcitygavin charmcitygavin Awaiting requested review from charmcitygavin

@13bfrancis 13bfrancis Awaiting requested review from 13bfrancis

@RanyeM RanyeM Awaiting requested review from RanyeM

@andieswift andieswift Awaiting requested review from andieswift

@rmuntaqim rmuntaqim Awaiting requested review from rmuntaqim

Assignees

@tbolt tbolt

Labels
released on @val
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbolt @asharonbaltazar