-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sqs4ses): replace Kafka Connector Direct with Kafka to queue, then queue to email. #1072
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 92141fe.
benjaminpaige
had a problem deploying
to
c-emails
January 28, 2025 04:07 — with
GitHub Actions
Failure
benjaminpaige
had a problem deploying
to
c-emails
January 28, 2025 04:07 — with
GitHub Actions
Failure
Why are you deleting processemails? We have a lot of unit test that depend on that, and if this is a refactor you will need to update the test appropriately. |
thwalker6
requested changes
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure we dont lose any coverage on this. A lot of test go through this handler
benjaminpaige
changed the title
C emails
feat(sqs4ses): replace Kafka Connector Direct with Kafka to queue, then queue to email.
Jan 28, 2025
* updated getNextBusinessDay to getBusinessDay and returning the end of the day * updated DateRange to use this new method * updated tests to expect end of day
…Tool (#1066) * add potentially working code * console logs * add email logic * add watch topic * Update email.ts * Update email.ts * Update processEmails.ts * Update email.ts * Update email.ts * Update email.ts * Update processEmails.ts * Update email.ts * figuring out logic * continue * fix logs * Update processEmails.ts * Update processEmails.ts * Update processEmails.ts * Update index.ts * Update processEmails.ts * Update processEmails.ts * Update index.ts * test * Update index.ts * Update processEmails.ts * Update processEmails.ts * Update processEmails.ts * Update processEmails.ts * Update processEmails.ts * Update processEmails.ts * add more logging * Update processEmails.ts * Update processEmails.ts * Update processEmails.ts * Update processEmails.ts * Update processEmails.ts * Update processEmails.ts * Update processEmails.ts * Update processEmails.ts * Update processEmails.ts * rename triggers * cleanup * Update processEmails.ts * Update index.ts * Update processEmails.ts * lint * Update processEmails.ts * testing * Update processEmails.ts --------- Co-authored-by: 13bfrancis <[email protected]>
benjaminpaige
had a problem deploying
to
c-emails
January 28, 2025 16:44 — with
GitHub Actions
Failure
benjaminpaige
had a problem deploying
to
c-emails
January 28, 2025 16:44 — with
GitHub Actions
Failure
* add med spa mock item * fix tests * fix test
benjaminpaige
had a problem deploying
to
c-emails
January 28, 2025 16:53 — with
GitHub Actions
Failure
benjaminpaige
had a problem deploying
to
c-emails
January 28, 2025 16:53 — with
GitHub Actions
Failure
benjaminpaige
had a problem deploying
to
c-emails
January 28, 2025 16:57 — with
GitHub Actions
Failure
benjaminpaige
had a problem deploying
to
c-emails
January 28, 2025 16:57 — with
GitHub Actions
Failure
Coverage Report
File Coverage
|
benjaminpaige
had a problem deploying
to
c-emails
January 28, 2025 17:02 — with
GitHub Actions
Failure
benjaminpaige
had a problem deploying
to
c-emails
January 28, 2025 17:02 — with
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
| Email processing pipeline lacks delay queue between Kafka and Lambda functions. | Introduced an SQS delay queue to improve fault tolerance and added monitoring for delays and errors. |
🔧 Changes
processEmails.ts
to handle both Kafka and SQS events:processEmails.ts
:SendMessageCommand
.email.ts
stack:🚀 How to Test
DELAY_QUEUE_URL
) are set correctly in the Lambda configurations.📄 Additional Notes
processEmails.ts
handler now logs detailed debug information for both Kafka and SQS events, aiding in identifying potential issues.