fix(mocks): Edit SPA mock item ID format #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiffanyvu
commented
Jan 27, 2025
| @@ -25,7 +25,7 @@ describe("getPackageActions test", () => { | |||
| }); | |||
|
|
|||
| it("should return empty actions for package without actions", async () => { | |||
| const actions = await getPackageActions(TEST_ITEM_ID); | |||
| const actions = await getPackageActions(TEST_SPA_ITEM_ID); | |||
There was a problem hiding this comment.
I changed this because the SPA item had actions apparently?
Coverage Report
File CoverageNo changed files found. |
tiffanyvu
temporarily deployed
to
fix-mockitems
GitHub Actions
Inactive
tiffanyvu
temporarily deployed
to
fix-mockitems
GitHub Actions
Inactive
tiffanyvu
temporarily deployed
to
fix-mockitems
GitHub Actions
Inactive
tiffanyvu
temporarily deployed
to
fix-mockitems
GitHub Actions
Inactive
tiffanyvu
temporarily deployed
to
fix-mockitems
GitHub Actions
Inactive
benjaminpaige
pushed a commit
that referenced
this pull request
Jan 28, 2025
* add med spa mock item * fix tests * fix test
RanyeM
pushed a commit
that referenced
this pull request
Jan 28, 2025
* add med spa mock item * fix tests * fix test
|
🎉 This PR is included in version 1.5.0-val.116 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Linked Ticket
Ticket to close
💬 Description / Notes
In my split spa ticket, I would like to use the mock Medicaid SPA item in my unit tests. However when using it I found that the mock item has the wrong ID format.
🛠 Changes
Another mock data item has been added to represent a Medicaid SPA item. The authority of the previous mock item has been updated to match the ID based on its format. Any tests that were referring to this ID were modified accordingly.
📸 Screenshots / Demo