Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FAQ): Update Implementation Guide PDFs to the most recent versions #1063

Merged
merged 14 commits into from
Jan 28, 2025
Merged

feat(FAQ): Update Implementation Guide PDFs to the most recent versions #1063

merged 14 commits into from
Jan 28, 2025

Conversation

charmcitygavin
Copy link
Collaborator

🎫 Linked Ticket

OY2-31990

💬 Description / Notes

The OneMAC FAQ had outdated implementation guide PDFs. This ticket updates them with the latest versions provided in OY2-31756.

The original ticket lacked some information we tracked down:

  • Some PDFs had "Final" while others had "Draft" in their filenames, causing confusion. We had to pause work to get clarity on these files. It turned out that they are all final and approved files, regardless of whether they were labeled "Final" or Draft.
  • We were also asked to remove the "Final" or "Draft" parts of the filenames, though this was not included in the original ticket.
  • There was a missing PDF for the CS 13 implementation guide.
  • CS 14 needed to be removed from both the templates and implementation guide sections.

Additionally, ABP 2c was missing from the templates and IG sections, so I added those missing files.

🛠 Changes

The old PDFs were removed, new PDFs added, and the filenames were changed based on feedback.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 24, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 85.79% 4033 / 4701
🔵 Statements 85.22% 4394 / 5156
🔵 Functions 76.85% 1192 / 1551
🔵 Branches 70.08% 1947 / 2778
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
react-app/src/features/faq/content/abpGuides.ts 100% 100% 100% 100%
react-app/src/features/faq/content/abpTemplate.ts 100% 100% 100% 100%
react-app/src/features/faq/content/chpTemplates.ts 100% 100% 100% 100%
react-app/src/features/faq/content/mpcTemplates.ts 100% 100% 100% 100%
Generated in workflow #1769 for commit 6e859bf by the Vitest Coverage Report Action

@charmcitygavin charmcitygavin marked this pull request as ready for review January 24, 2025 17:10
asharonbaltazar
asharonbaltazar approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@asharonbaltazar asharonbaltazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where's the code 😂?

@charmcitygavin charmcitygavin merged commit f77940f into main Jan 28, 2025
15 checks passed
@charmcitygavin charmcitygavin deleted the update-ig branch January 28, 2025 21:25
RanyeM pushed a commit that referenced this pull request Jan 28, 2025
@charmcitygavin @RanyeM
feat(FAQ): Update Implementation Guide PDFs to the most recent versio…
7e58b38 
…ns (#1063)

* Update ABP implementation guide PDFs

* Partial update of CHIP IG PDFs

Waiting on answer to question about files attached to ticket marked as "draft"

* Update MPC (a.k.a. PCS) IG PDFs to final versions

* Update ABP IG file names per feedback

* Add missing ABP 2c template PDF

* Remove CS 14 per Jonathan Campbell's feedback

https://jiraent.cms.gov/browse/OY2-31990?focusedId=3640630&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-3640630

* Update CS 13 IG with new file

* Update CHP IG filenames per feedback

* Update MPC IG filenames per feedback

* Fix link
@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 1.5.0-val.117 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asharonbaltazar asharonbaltazar asharonbaltazar approved these changes

@RanyeM RanyeM Awaiting requested review from RanyeM

Assignees
No one assigned
Labels
released on @val
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charmcitygavin @asharonbaltazar