Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(te/appk): Adding initial temp extension emails and appk for b's and c's #1049

Merged
merged 5 commits into from
Jan 22, 2025

Conversation

benjaminpaige
Copy link
Collaborator

@benjaminpaige benjaminpaige commented Jan 21, 2025

🎫 Linked Ticket

Ticket to close

💬 Description / Notes

This pull request introduces and unifies the new app-k event within our email templates and shared types. Previously, there were references to NewAppKSubmission that are now replaced with AppKSubmission. The changes ensure the new submission type is fully recognized and handled in our email templates for both state and CMS recipients.

Additionally, we updated the processEmailsHandler.test.ts test suite to include the appk event scenario, ensuring coverage for the new event type. A minor change was also made to rename "temp-extension" to "temporary-extension" for clarity and consistency in our EmailTemplates.

🛠 Changes

  1. Rename NewAppKSubmission to AppKSubmission in shared types and all associated email templates.
  2. Add "app-k" to EmailTemplates to handle AppKSubmission events properly.
  3. Update processEmailsHandler.test.ts to include new test cases referencing the appk submission type under 1915(b) and 1915(c).
  4. Rename the "temp-extension" key to "temporary-extension" in EmailTemplates for clarity.
  5. Adjust typed props for various email components (e.g., TempExtCMSEmail, TempExtStateEmail) to include the emails field from EmailAddresses.

📸 Screenshots / Demo

No UI changes were introduced in this PR, so no screenshots are applicable.

Copy link
Contributor

github-actions bot commented Jan 21, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 80.14% 3745 / 4673
🔵 Statements 79.44% 4073 / 5127
🔵 Functions 70.25% 1084 / 1543
🔵 Branches 61.55% 1697 / 2757
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
lib/libs/email/index.ts 68.57% 50% 83.33% 67.64% 87-88, 124-125, 130-132, 138-139, 144-145
lib/libs/email/content/newSubmission/index.tsx 100% 100% 100% 100%
lib/libs/email/content/newSubmission/emailTemplates/AppKCMS.tsx 100% 100% 100% 100%
lib/libs/email/content/newSubmission/emailTemplates/AppKState.tsx 100% 100% 100% 100%
lib/libs/email/content/tempExtension/index.tsx 100% 100% 100% 100%
lib/libs/email/content/tempExtension/emailTemplates/TempExtCMS.tsx 100% 100% 100% 100%
lib/libs/email/content/tempExtension/emailTemplates/TempExtState.tsx 100% 100% 100% 100%
lib/libs/email/preview/InitialSubmissions/CMS/AppK.tsx 0% 100% 0% 0% 5-21
lib/libs/email/preview/InitialSubmissions/CMS/Temp_Extension.tsx 100% 100% 100% 100%
lib/libs/email/preview/InitialSubmissions/State/Temp_Extension.tsx 100% 100% 100% 100%
lib/packages/shared-types/events/app-k.ts 100% 100% 100% 100%
lib/packages/shared-types/events/index.ts 100% 100% 100% 100%
Generated in workflow #1582 for commit d27d8ac by the Vitest Coverage Report Action

Copy link
Collaborator

@asharonbaltazar asharonbaltazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you somehow get rid of the any in Temp_Extension.tsx and Temp_Extension.tsx? It just needs a props update, I'm sure

@benjaminpaige
Copy link
Collaborator Author

Could you somehow get rid of the any in Temp_Extension.tsx and Temp_Extension.tsx? It just needs a props update, I'm sure

good idea, done and done.

Copy link
Contributor

🎉 This PR is included in version 1.5.0-val.111 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

RanyeM pushed a commit that referenced this pull request Jan 23, 2025
…and c's (#1049)

* Update with tempExt and appks

* Addd 1915b appks

* Update

* Update

* Update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants