-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(te/appk): Adding initial temp extension emails and appk for b's and c's #1049
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you somehow get rid of the any
in Temp_Extension.tsx
and Temp_Extension.tsx
? It just needs a props update, I'm sure
good idea, done and done. |
🎉 This PR is included in version 1.5.0-val.111 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
…and c's (#1049) * Update with tempExt and appks * Addd 1915b appks * Update * Update * Update
🎫 Linked Ticket
Ticket to close
💬 Description / Notes
This pull request introduces and unifies the new
app-k
event within our email templates and shared types. Previously, there were references toNewAppKSubmission
that are now replaced withAppKSubmission
. The changes ensure the new submission type is fully recognized and handled in our email templates for both state and CMS recipients.Additionally, we updated the
processEmailsHandler.test.ts
test suite to include theappk
event scenario, ensuring coverage for the new event type. A minor change was also made to rename"temp-extension"
to"temporary-extension"
for clarity and consistency in ourEmailTemplates
.🛠 Changes
NewAppKSubmission
toAppKSubmission
in shared types and all associated email templates."app-k"
toEmailTemplates
to handleAppKSubmission
events properly.processEmailsHandler.test.ts
to include new test cases referencing theappk
submission type under 1915(b) and 1915(c)."temp-extension"
key to"temporary-extension"
inEmailTemplates
for clarity.TempExtCMSEmail
,TempExtStateEmail
) to include theemails
field fromEmailAddresses
.📸 Screenshots / Demo
No UI changes were introduced in this PR, so no screenshots are applicable.