Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(faq): update answers to look like lists #1047

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(faq): update answers to look like lists #1047

wants to merge 4 commits into from
+67 −64

Conversation

asharonbaltazar
Copy link
Collaborator

@asharonbaltazar asharonbaltazar commented Jan 21, 2025 •
edited
Loading

🎫 Linked Tickets

OY2-32034
OY2-32035
OY2-32036
OY2-32037
OY2-32032

💬 Description / Notes

I didn't feel it was necessary to extract these patterns into a component. Everything's contained in one file, so it feels overkill to make a component, especially when we consider the slight variations between every answer

🛠 Changes

className and markup changes

📸 Screenshots / Demo

Screenshot 2025-01-21 at 12 36 36 PM

Screenshot 2025-01-21 at 12 36 19 PM

@asharonbaltazar asharonbaltazar requested a review from tbolt January 21, 2025 17:36
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 21, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 80.14% 3745 / 4673
🔵 Statements 79.44% 4073 / 5127
🔵 Functions 70.25% 1084 / 1543
🔵 Branches 61.55% 1697 / 2757
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
react-app/src/features/faq/content/oneMACFAQContent.tsx 63.15% 20% 90.9% 63.15% 282-289
Generated in workflow #1587 for commit 6151e57 by the Vitest Coverage Report Action

tbolt
tbolt approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@tbolt tbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, nice work.

I didn't feel it was necessary to extract these patterns into a component

Agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdinh8124 jdinh8124 jdinh8124 approved these changes

@tbolt tbolt tbolt approved these changes

@13bfrancis 13bfrancis Awaiting requested review from 13bfrancis

@RanyeM RanyeM Awaiting requested review from RanyeM

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asharonbaltazar @tbolt @jdinh8124