-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Saving files locally in both yaml and json format. #904
Conversation
🦋 Changeset detectedLatest commit: c6db596 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not what we discussed. Please make changes such that:
- The global hidden ensemble folder keeps track of which apps exist on the local file system and where to find them, i.e. the paths
- The app metadata is stored in the same folder as the YAML sub directories.
Do not flatten the code organization into generic files, e.g. enums
, utilities
, constants
. Keep code organized in vertical modules that correspond to a specific function, e.g. local
- node, dto
- models, firebase
- cloud
Visit the preview URL for this PR (updated for commit c6db596): https://react-kitchen-sink-dev--pr904-tayyab-local-files-926y0bfw.web.app (expires Fri, 22 Nov 2024 23:23:51 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6267897ade2ba783b6db70a53a60fc3946d625e9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still needs quite a bit of work.
|
||
const getYamlFolderPath = async ( | ||
appId: string, | ||
yamlFolder: string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this for? Since the app can be anywhere on the local FS I don't see the point of adding another path here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since app can be anywhere on the FS this is the global metadata file to keep track of yaml folder on the fs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then what is the difference between YAMLFolder and GlobalFolder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea was in the future users could update the path of App Yaml files from the web studio if they had moved the app from anywhere. This Yaml Folder path will act as a fallback path if they accidentally remove the Yaml Filepath to save the app data again.
44f39a5
to
603c773
Compare
8b12e3f
to
ead03f3
Compare
73e0ce6
to
9ac69ee
Compare
9ac69ee
to
346d026
Compare
847ba2d
to
8e87ba5
Compare
Describe your changes
Screenshots [Optional]
Issue ticket number and link
Closes #
Checklist before requesting a review
pnpm changeset add