Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added support for nested items in menu #1060

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sagardspeed2
Copy link
Contributor

@sagardspeed2 sagardspeed2 commented Mar 17, 2025

Describe your changes

Added support for nested items in menu

Screenshots [Optional]

Issue ticket number and link

Closes #1059

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests
  • I have added a changeset pnpm changeset add
  • I have added example usage in the kitchen sink app

@sagardspeed2 sagardspeed2 self-assigned this Mar 17, 2025
Copy link

changeset-bot bot commented Mar 17, 2025

🦋 Changeset detected

Latest commit: 74e8310

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@ensembleui/react-kitchen-sink Patch
@ensembleui/react-runtime Patch
@ensembleui/react-preview Patch
@ensembleui/react-starter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 17, 2025

Visit the preview URL for this PR (updated for commit 74e8310):

https://react-kitchen-sink-dev--pr1060-1059-support-for-nes-4w01pn8k.web.app

(expires Fri, 28 Mar 2025 14:54:15 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6267897ade2ba783b6db70a53a60fc3946d625e9

@justEhmadSaeed
Copy link
Member

@sagardspeed2
when we add the children to a menu item, it stops following the sidebar styles.
image

@justEhmadSaeed
Copy link
Member

also, we might be needing the support for customItem in the sub-menu as we're doing it for main menu items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Sidebar's sub menu items to be active when selected
3 participants