-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: modularize icons #1005
base: main
Are you sure you want to change the base?
fix: modularize icons #1005
Conversation
🦋 Changeset detectedLatest commit: d1a5be4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Visit the preview URL for this PR (updated for commit d1a5be4): https://react-kitchen-sink-dev--pr1005-185-modularize-icons-9hcvk2ay.web.app (expires Fri, 14 Feb 2025 12:59:47 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6267897ade2ba783b6db70a53a60fc3946d625e9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be generalized to allow any IconSet, not just specially handing MUI Icons.
If you don't import the entire icon set and instead only import the ones that are used, does that reduce the bundle size further?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some tests for Icon/Avatar component.
Describe your changes
reduce runtime bundle size by modularize icons
Screenshots [Optional]
Issue ticket number and link
Closes #185
Checklist before requesting a review
pnpm changeset add