Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modularize icons #1005

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

fix: modularize icons #1005

wants to merge 8 commits into from

Conversation

sagardspeed2
Copy link
Contributor

@sagardspeed2 sagardspeed2 commented Jan 22, 2025

Describe your changes

reduce runtime bundle size by modularize icons

Screenshots [Optional]

Issue ticket number and link

Closes #185

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests
  • I have added a changeset pnpm changeset add
  • I have added example usage in the kitchen sink app

@sagardspeed2 sagardspeed2 requested a review from evshi January 22, 2025 17:06
@sagardspeed2 sagardspeed2 self-assigned this Jan 22, 2025
Copy link

changeset-bot bot commented Jan 22, 2025

🦋 Changeset detected

Latest commit: d1a5be4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@ensembleui/react-framework Patch
@ensembleui/react-kitchen-sink Patch
@ensembleui/react-runtime Patch
@ensembleui/react-preview Patch
@ensembleui/react-starter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 22, 2025

Visit the preview URL for this PR (updated for commit d1a5be4):

https://react-kitchen-sink-dev--pr1005-185-modularize-icons-9hcvk2ay.web.app

(expires Fri, 14 Feb 2025 12:59:47 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6267897ade2ba783b6db70a53a60fc3946d625e9

Copy link
Contributor

@evshi evshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be generalized to allow any IconSet, not just specially handing MUI Icons.

If you don't import the entire icon set and instead only import the ones that are used, does that reduce the bundle size further?

Copy link
Contributor

@evshi evshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some tests for Icon/Avatar component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modularize Icons
2 participants