Show Strain menu iff genome has strain gene trees #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @imransl This looks fine to me. Thanks ! |
|
Is the sandbox still updated with this PR @twalsh-ebi ? |
|
Merging as it needs to be in for 113. But please test it on rc.ensembl.org |
jyothishnt
added a commit
that referenced
this pull request
Sep 24, 2024
* postreleasefix/113: Show Strain menu iff genome has strain gene trees (#1038)
jyothishnt
added a commit
that referenced
this pull request
Sep 24, 2024
* postreleasefix/113: Show Strain menu iff genome has strain gene trees (#1038)
|
My apologies @jyothishnt, I had moved things around when testing a different PR and had not moved things back in time for the review. In any case, it looks like the changes have been successful on the RC site. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some genomes that have strain metadata in their core database but are not in a strain-level gene-tree collection. Currently a Strains submenu is shown for these genomes, but this Strains submenu is unnecessary in such cases and could be removed.
This PR removes the Strains submenu in such cases.
Views affected
This affects the gene view of genomes that have strain metadata but are not in a strain-level gene-tree collection.
Here are some examples of such genomes. In these cases, a Strains menu is not needed:
For comparison, here are some examples of genomes in the Wheat cultivars protein-tree collection, for which a Strains menu is expected to appear:
Here are some further examples of genomes in the Pig breeds protein-tree collection, for which a Strains menu is expected to appear:
Possible complications
None expected.
Merge conflicts
None detected.
Related JIRA Issues (EBI developers only)