Launch amp-google-document-embed (ampproject#17368)

Enriqe · Nov 28, 2018 · 3b5da8d · 3b5da8d
1 parent 69a989b
commit 3b5da8d
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 16 deletions.
diff --git a/extensions/amp-google-document-embed/0.1/amp-google-document-embed.js b/extensions/amp-google-document-embed/0.1/amp-google-document-embed.js
@@ -29,7 +29,6 @@
 
 import {addParamToUrl} from '../../../src/url';
 import {dev, user} from '../../../src/log';
-import {isExperimentOn} from '../../../src/experiments';
 import {isLayoutSizeDefined} from '../../../src/layout';
 import {removeElement} from '../../../src/dom';
 
@@ -75,8 +74,6 @@ export class AmpDriveViewer extends AMP.BaseElement {
 
   /** @override */
   buildCallback() {
-    user().assert(isExperimentOn(this.win, 'amp-google-document-embed'),
-        'Experiment amp-google-document-embed is disabled');
     user().assert(
         this.element.getAttribute('src'),
         'The src attribute is required for <amp-google-document-embed> %s',

diff --git a/extensions/amp-google-document-embed/0.1/test/test-amp-google-document-embed.js b/extensions/amp-google-document-embed/0.1/test/test-amp-google-document-embed.js
@@ -14,8 +14,7 @@
  * limitations under the License.
  */
 
-import {TAG} from '../amp-google-document-embed';
-import {toggleExperiment} from '../../../../src/experiments';
+import '../amp-google-document-embed';
 
 describes.realWin('amp-google-document-embed', {
   amp: {
@@ -27,7 +26,6 @@ describes.realWin('amp-google-document-embed', {
   beforeEach(() => {
     win = env.win;
     doc = win.document;
-    toggleExperiment(win, TAG, true);
   });
 
   function getDriveViewer(src, opt_responsive) {

diff --git a/extensions/amp-google-document-embed/amp-google-document-embed.md b/extensions/amp-google-document-embed/amp-google-document-embed.md
@@ -30,10 +30,9 @@ limitations under the License.
     <td>fill, fixed, fixed-height, flex-item, nodisplay, responsive</td>
   </tr>
   <tr>
-    <td width="40%"><strong>Availability</strong></td>
-    <td><div><a href="https://www.ampproject.org/docs/reference/experimental.html">Experimental</a></td>
+    <td width="40%"><strong>Examples</strong></td>
+    <td>See AMP By Example's <a href="https://ampbyexample.com/components/amp-google-document-embed/">amp-google-document-embed example</a>.</td>
   </tr>
-  <!-- TODO(cvializ): Make examples -->
 </table>
 
 [TOC]

diff --git a/tools/experiments/experiments.js b/tools/experiments/experiments.js
@@ -302,13 +302,6 @@ const EXPERIMENTS = [
     spec: 'https://github.com/ampproject/amphtml/issues/3434',
     cleanupIssue: 'https://github.com/ampproject/amphtml/issues/15158',
   },
-  {
-    id: 'amp-google-document-embed',
-    name: 'Enables the experiment amp-google-document-embed component' +
-        ' which is a wrapper around the Google Drive document viewer embed.',
-    spec: 'TODO',
-    cleanupIssue: 'TODO',
-  },
   {
     id: 'amp-image-slider',
     name: 'Enables the experimental amp-image-slider for image comparison',