✨ 将设置界面独立为一个窗口 #75
Draft
✨ 将设置界面独立为一个窗口 #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goodjooy
requested changes
Jul 25, 2024
Comment on lines
+3
to
+24
| #[command] | ||
| pub async fn open_setting_page(handle: AppHandle) { | ||
| let setting_page = handle.get_window("settings").unwrap(); | ||
| // 居主页面之中 | ||
| setting_page.center().unwrap(); | ||
| setting_page.show().unwrap(); | ||
| setting_page.set_focus().unwrap(); | ||
| setting_page | ||
| .clone() | ||
| .on_window_event(move |event| { | ||
| if let WindowEvent::CloseRequested { api, .. } = event { | ||
| api.prevent_close(); | ||
| setting_page.hide().unwrap(); | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| #[command] | ||
| pub async fn close_setting_page(handle: AppHandle) { | ||
| let setting_window = handle.get_window("settings").unwrap(); | ||
| setting_window.hide().unwrap(); | ||
| } |
Comment on lines
+3
to
+4
| #[command] | ||
| pub async fn open_setting_page(handle: AppHandle) { |
There was a problem hiding this comment.
这里面的都是tauri的api返回的Result，可以将接口返回写为 Result<(), tauri::Error> 然后去除内部的unwrap
Comment on lines
147
to
+171
| const setting = reactive<{ | ||
| // auto boot setting | ||
| autoBoot: boolean, | ||
| initAutoBoot: () => void, | ||
| setAutoBoot: () => void, | ||
| // quit | ||
| close: () => void, | ||
| checkUpdate: () => void | ||
| autoBoot: boolean; | ||
| initAutoBoot: () => void; | ||
| setAutoBoot: () => void; | ||
| // quit | ||
| close: () => void; | ||
| checkUpdate: () => void; | ||
| // notification | ||
| notify_mode: { idx: number, tip: string, value: string }, | ||
| initNotifyMode: () => void | ||
| setNotifyMode: () => void | ||
| notify_mode: { idx: number; tip: string; value: string }; | ||
| initNotifyMode: () => void; | ||
| setNotifyMode: () => void; | ||
| //version | ||
| currentVersion: string, | ||
| getAppVersion: () => void | ||
| currentVersion: string; | ||
| getAppVersion: () => void; | ||
| }>({ | ||
| currentVersion: "", | ||
| getAppVersion: () => { | ||
| app.getVersion().then((version) => { | ||
| setting.currentVersion = version | ||
| }) | ||
| setting.currentVersion = version; | ||
| }); | ||
| }, | ||
| notify_mode: NotifyMode.PopUpAndBeep, | ||
| initNotifyMode: () => { | ||
| notification.getNotificationMode() | ||
| .then((v) => setting.notify_mode = v) | ||
| notification.getNotificationMode().then((v) => (setting.notify_mode = v)); |
There was a problem hiding this comment.
我觉得这边设置可以通过后端来动态处理，而不是现在这样写死
| <v-app class="setting"> | ||
|
|
||
| <div > | ||
| <v-app-bar title="设置" id="drag" color="#e6a23c" density="compact" data-tauri-drag-region> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
已知问题