Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving the images of Podcast-Cover, Testimonials, Podcast-Hosts, People, Blog and Advertisement to Astro Image processing to use WebP #638

Merged
merged 8 commits into from
Nov 20, 2023

Conversation

andygrunwald
Copy link
Contributor

@andygrunwald andygrunwald commented Nov 17, 2023

Moving the images of

to Astro Image processing to use WebP.

I apologize for his Pull Request being pretty big.
Most of the changes are

  1. Moving images from /public into /src
  2. Adjusting image pathes

Overall, this Pull Request "just" implements https://docs.astro.build/en/guides/images/.

Related #58

Website size

A few numbers about our current page size of https://engineeringkiosk.dev/.
Those are useful to compare once this change is merged.

https://engineeringkiosk.dev/

Screenshot 2023-11-17 at 20 51 06

https://engineeringkiosk.dev/podcast/

Screenshot 2023-11-17 at 20 51 35

Copy link

netlify bot commented Nov 17, 2023

Deploy Preview for nifty-bardeen-5c7e53 ready!

Name Link
🔨 Latest commit 81e9f4a
🔍 Latest deploy log https://app.netlify.com/sites/nifty-bardeen-5c7e53/deploys/655b3db9de8d5100086a0102
😎 Deploy Preview https://deploy-preview-638--nifty-bardeen-5c7e53.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

* main:
  Bump @astrojs/mdx from 1.1.4 to 1.1.5
  Bump prettier-plugin-astro from 0.12.1 to 0.12.2
  Bump prettier from 3.0.3 to 3.1.0
  Bump astro from 3.5.3 to 3.5.5
  Remove unused images
  Update src/data/german_tech_podcasts.json with latest podcast data
@andygrunwald andygrunwald merged commit 9f151ba into main Nov 20, 2023
5 checks passed
@andygrunwald andygrunwald deleted the podcast-images-astro-webp branch November 20, 2023 19:52
@andygrunwald
Copy link
Contributor Author

https://engineeringkiosk.dev/

After merge:
Screenshot 2023-11-20 at 20 58 26

What Normal WebP
requests 59 42
transferred 1,3 MB 345 KB
Finish 520 ms 471 ms
DOMContentLoaded 280 ms 81 ms
Load 490 ms 444 ms

https://engineeringkiosk.dev/podcast/

Screenshot 2023-11-20 at 20 58 43
What Normal WebP
requests 127 29
transferred 6 MB 373 KB
Finish 586 ms 337 ms
DOMContentLoaded 162 ms 122 ms
Load 563 ms 306 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant