WorldGuard-Folia #2060
Draft
WorldGuard-Folia #2060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see there is already a WorldGuard folia so perhaps you want to go with that one. Either way, it is alright. |
Joo200
reviewed
Jan 28, 2024
README.md
Outdated
Comment on lines
40
to
44
| # Folia Inquisitors | ||
| [<img src="https://github.com/Folia-Inquisitors.png" width=80 alt="Folia-Inquisitors">](https://github.com/orgs/Folia-Inquisitors/repositories) | ||
| [<img src="https://github.com/TechnicallyCoded.png" width=80 alt="TechnicallyCoded">](https://github.com/TechnicallyCoded) | ||
| [<img src="https://github.com/Yomamaeatstoes.png" width=80 alt="Yomamaeatstoes">](https://github.com/Yomamaeatstoes) | ||
|
|
There was a problem hiding this comment.
Same as in WorldEdit:
EngineHub/WorldEdit#2462 (comment)
There was a problem hiding this comment.
Heyy @Joo200 I have updated it. What do you think of it now?
worldguard-bukkit/src/main/java/com/sk89q/worldguard/bukkit/WorldGuardPlugin.java
Outdated
Show resolved
Hide resolved
| @@ -52,19 +53,22 @@ public Optional<Field> load(Class<?> clazz) throws Exception { | |||
| public SchedulerReport() { | |||
| super("Scheduler"); | |||
|
|
|||
| List<BukkitTask> tasks = Bukkit.getServer().getScheduler().getPendingTasks(); | |||
| append("Error", "MODDED FOLIA VERSION - DO NOT REPORT TO WORLDGUARD"); | |||
There was a problem hiding this comment.
That looks like it's not finished yet? Please don't remove the whole report.
There was a problem hiding this comment.
Whoops, sorry about that. Originally I wasn’t intending to PR it so I put a comment there so people wouldn’t spam you guys if they found my fork. It seems I forgot to remove that comment.
There was a problem hiding this comment.
Having looked closer into this, until TechnicallyCoded adds a method to getAllWrappedTasks either active or pending. I will contact him as he is a work colleague.
…rldGuardPlugin.java. Fixed cancelling of Bukkit tasks if not running on Folia. Made SessionManager task async. Updated PaperAPI to 1.20.2. Fixed plugin.yml formatting. Updated README.md to reflect new project member(@Loving11ish).
Updated FoliaLib dependency. Fixed ProcessPlayerEvent scheduler in Wo…
…rReport.java. Re-added Bukkit task reports in SchedulerReport.java.
Update upstream
* Fix silent flag for gameplay commands This issue has been fixed in CommandBook with EngineHub/CommandBook@6448031 but never in WorldGuard. Co-authored-by: Wyatt Childers <[email protected]> * codestyle
* Fix checking bypass on initialize * Add SessionManager#createSession back as deprecated
* Fix ItemStack conversion on block place This issue is present in 1.21 because some materials do not convert 1:1 to item types. This throws an exception in the ItemStack constructor. Example: WALL_TORCH is a valid block but not a valid item, only TORCH is a valid item. So, use the item in hand instead, creating a copy with quantity set to 1, for issueing the use item event. * Use ItemStack as-is. Closes EngineHub#2092. --------- Co-authored-by: wizjany <[email protected]>
* Fix compilation for MC 1.21. Nothing tested yet. * Update Materials.java with 1.21 tags and materials * Fix ItemStack conversion on block place on MC 1.21 (EngineHub#2093) * Fix ItemStack conversion on block place This issue is present in 1.21 because some materials do not convert 1:1 to item types. This throws an exception in the ItemStack constructor. Example: WALL_TORCH is a valid block but not a valid item, only TORCH is a valid item. So, use the item in hand instead, creating a copy with quantity set to 1, for issueing the use item event. * Use ItemStack as-is. Closes EngineHub#2092. * Fix ItemStack conversion for spigot compatibility * Special handling for WindCharges * Do not call as a bulk event, because it has to check every blocks type * WindCharge -> AbstractWindCharge * Fix UseBlockFlag for multiple uses at the same time, add windburst-flag * Cleanup code * Handle vaults as use, crafters as chest-access. --------- Co-authored-by: Joo200 <[email protected]> Co-authored-by: Lennart <[email protected]> Co-authored-by: Brokkonaut <[email protected]>
Idk why we even to this for betas, they're not getting a maven release.
Definitely did not accidentally make a 40MB jar halfway through.
Port buildlogic from WorldEdit
Upstream
There's no tag which has wood+copper, but iron are not interactable anyway. Relates to EngineHub#2130.
Note that bypass bypasses this if the player with bypass is the target of the potion, but only for the player with bypass. Fixes EngineHub#2134.
Player flag is build-checked (default false) and breeze flag is not (default true). Having multiple flags is ugly but if we need every bit of behavior to be manipulable this is the only way.
…tuff Optimize and cleanup explosion events from entities Fixes EngineHub#2099 and EngineHub#2097
* Create and implement moisture-change flag * Fix imports * Add comment * Actually read the value from config. Closes EngineHub#1879 --------- Co-authored-by: wizjany <[email protected]>
Also update the changelog.
Event abstraction sucks and everything needs rewriting.
This is already past the debounce so in theory it's not getting hit *often*, but I guess if it's really slow it'll still show up.
* Avoid using metadata storage if possible * Fix cause detection, use always on paper * Fix fat fingers Co-authored-by: aurora <[email protected]>
Entire command should eventually be removed.
Also this was supposed to be on a branch but I just realized I forgot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to edit whatever you want on this, or deny it.
If you have any requested changes let me know. I have been using this for the better part of a couple months. Perhaps like 4.