Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Add POC async implementation, example using storescp #542

Merged
merged 49 commits into from
Oct 23, 2024
Merged

ENH: Add POC async implementation, example using storescp #542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
3251368
ENH: Add POC async implementation, example using storescp
naterichman Jul 14, 2024
3140822
MAIN: Modify read_pdu to take in Buf trait.
naterichman Jul 25, 2024
b8d8200
MAIN: Implement PDataReader and PDataWriter with async
naterichman Aug 5, 2024
1f79816
MAIN: Finish implementing framing for reading
naterichman Aug 6, 2024
b37bea4
MAIN: Add POC async version of storescp and storescu
naterichman Aug 7, 2024
63e0736
MAIN: Cleaning up
naterichman Aug 7, 2024
d53c0f2
MAIN: Add implementation for AsyncRead to PDataReader
naterichman Aug 7, 2024
876aac9
MAIN: Enumerate specific needed features
naterichman Aug 7, 2024
dfd0fad
MAIN: Resolve unused imports and format code
naterichman Aug 7, 2024
5334e2d
MAIN: Fix implementation of poll_read and poll_write
naterichman Aug 7, 2024
250578c
MAIN: Formatting and fixing compilation warnings
naterichman Aug 7, 2024
b863798
MAIN: Simplify implementation of poll_read
naterichman Aug 8, 2024
fdccf13
MAIN: Review comments and implement async versions of tests
naterichman Aug 9, 2024
b73bb0d
MAIN: Add github workflow for async feature flag
naterichman Aug 9, 2024
113b7f7
MAIN: Enumerate needed tokio features
naterichman Aug 9, 2024
0b62586
MAIN: Fix warnings and compilation errors
naterichman Aug 9, 2024
4830f2f
MAIN: Fix CI issues
naterichman Aug 11, 2024
b813690
Merge remote-tracking branch 'origin/master' into async
naterichman Aug 14, 2024
0399fb8
MAIN: Update some locks
naterichman Aug 27, 2024
8c5ac5b
MAIN: Relax requirements for bytes and tokio
naterichman Aug 27, 2024
5a4c274
MAIN: Fix !552 in async code as well :)
naterichman Aug 30, 2024
484225d
ENH: Move async to separate modules
naterichman Sep 5, 2024
9750459
MAIN: More work updating to separate modules
naterichman Sep 5, 2024
de9ab0b
MAIN: Fix tests and doctests [skip ci]
naterichman Sep 5, 2024
d7ea692
MAIN: Fix implementation of send_pdata
naterichman Sep 6, 2024
f833f00
ENH: Update storescu with new implementation
naterichman Sep 6, 2024
5a4dd25
Merge remote-tracking branch 'origin/master' into async
naterichman Sep 6, 2024
618bb93
MAIN: Fix warnings from beta toolchain
naterichman Sep 6, 2024
cc75478
MAIN: Format and use fully qualified names for TCPStream
naterichman Oct 4, 2024
687f03b
Merge remote-tracking branch 'origin/master' into async
naterichman Oct 4, 2024
e316a73
MAIN: Update store-scp with new ul code as well
naterichman Oct 4, 2024
a0554d9
Merge remote-tracking branch 'origin/master' into async
naterichman Oct 15, 2024
e03deff
DOC: Documentation on async
naterichman Oct 16, 2024
93fbdf4
ENH: Implement concurrent sending
naterichman Oct 16, 2024
ff97b48
MAIN: Make storescp blocking by default and change flag name
naterichman Oct 16, 2024
db6854d
MAIN: fmt
naterichman Oct 16, 2024
1b964fc
MAIN: Update deps
naterichman Oct 16, 2024
92a42a9
MAIN: Remove uneeded dep
naterichman Oct 16, 2024
6146d4c
MAIN: Apply review comment on concurrency help
naterichman Oct 16, 2024
ffae792
MAIN: Fix doctests
naterichman Oct 16, 2024
20416ad
MAIN: Add help for `non-blocking`
naterichman Oct 16, 2024
f01b396
MAIN: Box large error variants
naterichman Oct 16, 2024
bed7a3b
MAIN: fmt
naterichman Oct 16, 2024
c2b1a61
[ul] Add more "async" feature gates on test code
Enet4 Oct 17, 2024
26aac77
[ul] Tweak association::client documentation
Enet4 Oct 17, 2024
06fe10d
[ul] Remove async as a default feature, making it opt-in
Enet4 Oct 17, 2024
5929c2d
MAIN: Add more concrete example for handling pdu
naterichman Oct 17, 2024
521ec2a
MAIN: Fix poll_write implementation
naterichman Oct 21, 2024
f8f8cb3
MAIN: Clean up
naterichman Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ jobs:
- run: cargo test -p dicom-pixeldata --features gdcm
# test dicom-pixeldata without default features
- run: cargo test -p dicom-pixeldata --no-default-features
- run: cargo test -p dicom-ul --features async
Enet4 marked this conversation as resolved.
Show resolved Hide resolved
# run Clippy with stable toolchain
- if: matrix.rust == 'stable'
run: cargo clippy
Expand Down Expand Up @@ -60,4 +61,4 @@ jobs:
toolchain: stable
cache: true
- run: cargo check


Loading
Loading