Merge pull request #357 from EnergySystemsModellingLab/precommit-disa…

…ble-clippy-fix

`pre-commit`: Disable auto-fixing for clippy

.cargo/config.toml

@@ -0,0 +1,3 @@
+[alias]
+# Automatically fix clippy warnings (where possible)
+clipfix = "clippy --fix --allow-dirty --allow-staged"

.pre-commit-config.yaml

@@ -26,8 +26,6 @@ repos:
     rev: v1.0
     hooks:
       - id: clippy
-        # Warnings can be suppressed by adding "-A clippy::some_warning" to args
-        args: [--fix, --allow-dirty, --allow-staged, --, -D, clippy::all, -A, clippy::precedence]
   - repo: https://github.com/codespell-project/codespell
     rev: v2.2.6
     hooks:

docs/developer_guide.md

@@ -108,3 +108,10 @@ pre-commit install
 
 Thereafter, a series of checks should be run every time you commit with Git. In addition, the
 `pre-commit` hooks are also run as part of the CI pipeline.
+
+Note: you may get errors due to the [`clippy`] hook failing. In this case, you may be able to
+automatically fix them by running `cargo clipfix` (which we have defined as an alias in
+[`.cargo/config.toml`]).
+
+[`clippy`]: https://doc.rust-lang.org/clippy
+[`.cargo/config.toml`]: https://github.com/EnergySystemsModellingLab/MUSE_2.0/blob/main/.cargo/config.toml

src/input/region.rs

@@ -88,7 +88,6 @@ where
 }
 
 /// Try to insert a region ID into the specified map
-#[must_use]
 fn try_insert_region(
     entity_id: Rc<str>,
     region_id: &str,