Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide notes field from programme admin interface #4208

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

urbanwide
Copy link
Contributor

@urbanwide urbanwide commented Jan 30, 2025

Noticed that Nicky had added notes against programme activities and actions on test

It made me realise that notes against todos shouldn't be available to edit for programmes, as they are only intended to be used in audits as they are not translated. Assume this has been traditionally ok for them not to be translated for audits because the audit is all done in English too and not translated either.

https://trello.com/c/Pfi1FogC/3763-revise-programmes-to-include-adult-actions-and-not-just-pupil-activities

If we do want to add a shorter note, perhaps these should be added to activity type or intervention type models and not in the todo model. They would need to be translated too.

@urbanwide urbanwide marked this pull request as ready for review January 30, 2025 12:09
@urbanwide urbanwide requested a review from ldodds January 30, 2025 14:12
@urbanwide urbanwide merged commit f4c3058 into master Jan 30, 2025
20 checks passed
@urbanwide urbanwide deleted the hide-notes-field-for-programmes branch January 30, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants