Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Todos programme, activities and action index pages #4192

Merged

Conversation

urbanwide
Copy link
Contributor

@urbanwide urbanwide commented Jan 24, 2025

Activities and action index pages

  • - update the /intervention_type_groups index page to also have a programmes block like the activities page.
  • - for the programmes block on the actions page, the programmes in that list should only include those that have any adult actions.

I have not gone to town with the spec for the above, as I'm assuming these pages will need re-skinning at some point and therefore re-speccing.

Could do with some new text for inside the programme block now on activities and action index pages. Currently we have: Short programmes of related activities that pupils can work through step-by-step to achieve greater impact. Obviously now programmes can contain activities or actions and can be carried out by either pupil or adults. Maybe something like?
Short programmes of related tasks that pupils or adults can work through step-by-step to achieve greater impact.
image

  • - Update recommendations logic - was using old audit activities and actions relationships

Programme index page

  • - Update the programme index page to include some idea of the scope of the programme, e.g as a sentence above the one indicating the number of points to be scored:
“This programme is intended for pupils” (if there are no adult actions)
“This programme is intended for adults” (if there are no pupil activities)
“This programme is intended for the whole school” (if there are both).

Have added this to programme index and programme show pages. Also added an icon but not convinced there are icons that work for pupils / adults / whole school. See what you think:

Screenshot 2025-01-26 at 21 53 36 Screenshot 2025-01-26 at 21 53 27 Screenshot 2025-01-26 at 21 53 20

There is some redesign of these pages (programmes, activities / actions / recommendations) to be done but would like to chat on how we'd like to go about it first and perhaps do it in another PR later on.

Other

  • Only allow a programme to be repeated if school has not already completed it this academic year.

Old logic was allowing repeat if school had completed this programme in a previous academic year.
Which meant that - if the school had previously completed the programme in a different academic year, then completed it again this year, that when clicking repeat after this section completion (yes I know it's getting unlikely this will happen), if activities / actions had been completed this year already, the progress of those are automatically added when restarting a programme, meaning the programme would be automatically completed again. This would have allowed the school to continuously complete programmes by doing nothing, just clicking restart.

@urbanwide urbanwide marked this pull request as ready for review January 27, 2025 10:26
app/views/programme_types/_intention.html.erb Outdated Show resolved Hide resolved
app/views/programme_types/_intention.html.erb Outdated Show resolved Hide resolved
@ldodds
Copy link
Collaborator

ldodds commented Jan 27, 2025

For wording, how about something generic: "Short programmes of related tasks that can be worked through step-by-step to achieve greater impact"?

re: re-design. Suggest we get this set of features done before spending more time on this as the home page, etc updates will be more impactful.

When it comes to revisiting, I think we could use more components here, e.g.

  • a component for displaying a single activity/action/programme as a "card" or row in results
  • a component for showing a list of items, e.g. for recommendations or other card-deck use cases
  • a component for the individual task items, that handles their state
  • maybe one for an icon with a note, as you're using for intention and the programme status
  • in the dashboard redesign I did away for using card-deck and some of the flex options as they don't work very well on mobile, I found that using Bootstrap columns, with different breakpoints was generally enough
  • the styling of the card-decks should lift from the new wireframes which might mean: separately coloured backgrounds/callouts, different box styling (new design has more rounded corners), etc

@urbanwide
Copy link
Contributor Author

Thanks for the review and the discussion around the redesign @ldodds. That all makes good sense and I've added it to a separate Trello card so we don't lose it. Do you want a last check of this before I merge?

@urbanwide urbanwide requested a review from ldodds January 27, 2025 18:37
@urbanwide urbanwide merged commit c1d6525 into master Jan 28, 2025
20 checks passed
@urbanwide urbanwide deleted the 4724-todos-programme-activities-and-action-index-pages branch January 28, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants