Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make public displays feature accessible to users #4186

Merged
merged 6 commits into from
Jan 24, 2025

Conversation

ldodds
Copy link
Collaborator

@ldodds ldodds commented Jan 23, 2025

  • Change URL paths for feature, moving files around
  • Move index to a controller under /schools and ensure only school users can access
  • Add Manage My School link
  • Add Manage Group link
  • Revise school page to indicate if feature isn't available
  • Revise school page to include more instructions
  • Add School group index page with instructions
  • Provide option to download links for whole school group

@ldodds ldodds marked this pull request as ready for review January 23, 2025 18:02
@ldodds ldodds requested a review from urbanwide January 23, 2025 18:49
@urbanwide
Copy link
Contributor

urbanwide commented Jan 23, 2025

image
If you cut and paste the displayed link, it doesn't work. Took me a while to work out it is because digital_signage has an underscore in it and not a hyphen as per the actual route.

Which made me think about the other generated urls. Should they all consistently use hyphens rather than a mix of underscores and hyphens? i.e. currently you have:/pupils/schools/marksbury-c-of-e-primary-school/digital-signage/electricity/charts/out_of_hours. Should it be /pupils/schools/marksbury-c-of-e-primary-school/digital-signage/electricity/charts/out-of-hours

Copy link
Contributor

@urbanwide urbanwide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - a couple of questions, main one about the url structure.

@ldodds
Copy link
Collaborator Author

ldodds commented Jan 24, 2025

Thanks for review @urbanwide , have added translations, removed index method, fixed the in-page link, and tweaked the URL structure. Agree it was inconsistent and likely to cause confusion!

Did you want to look again before I merge?

Copy link
Contributor

@urbanwide urbanwide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

@ldodds ldodds merged commit 06c934b into master Jan 24, 2025
20 checks passed
@ldodds ldodds deleted the 4735-make-public-displays-feature-accessible-to-users branch January 24, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants