-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make public displays feature accessible to users #4186
Make public displays feature accessible to users #4186
Conversation
ldodds
commented
Jan 23, 2025
•
edited
Loading
edited
- Change URL paths for feature, moving files around
- Move index to a controller under /schools and ensure only school users can access
- Add Manage My School link
- Add Manage Group link
- Revise school page to indicate if feature isn't available
- Revise school page to include more instructions
- Add School group index page with instructions
- Provide option to download links for whole school group
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - a couple of questions, main one about the url structure.
Thanks for review @urbanwide , have added translations, removed index method, fixed the in-page link, and tweaked the URL structure. Agree it was inconsistent and likely to cause confusion! Did you want to look again before I merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍🏻