-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
13.0.0 #697
Merged
Merged
13.0.0 #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b8d771c.
lisicky
commented
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/check
vsubhuman
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
13.0.0
Serialization Changes:
Set Type Serialization: All set types are now serialized with a tag "258", which will become mandatory after the next hard fork (HF). There is no way to force serialization without the tag. The period between the current and the next era serves as a transition between the old CBOR format and the new CBOR format for sets.
Preservation of Original Transaction Bytes: Only the
FixedTransaction
type can preserve original transaction bytes. This is crucial when signing a transaction from a third party, as there is no guarantee that all CBOR types will be in a specific format.Redeemers Collection Serialization: The redeemers collection is now serialized as a map by default. After the next HF, redeemers will only be allowed as a map.
API Changes:
New Function
has_transaction_set_tag
: We've added thehas_transaction_set_tag
function to help you check if all sets in a transaction have the tag. It returnsTransactionSetsState
based on the transaction's content. This is useful for determining whether a transaction can be signed by a hardware wallet. In the case ofMixedSets
, it might be impossible to sign a transaction with a hardware wallet. Once the tag "258" becomes mandatory, we will remove thehas_transaction_set_tag
function.Removal of
hash_transaction
: Thehash_transaction
function has been removed because it cannot guarantee the correctness of a transaction hash for a transaction from a third-party tool. Instead, you should use theFixedTransaction
type.WARNING: If you need to sign a transaction from a third party, use the
FixedTransaction
type. Do not use theTransaction
type, as it is not serialization round-trip safe and the transaction hash might be incorrect.Examples:
Getting a Transaction Hash from a Third-Party Transaction:
Getting a Transaction Hash from a Transaction from a Transaction Builder:
Getting a Transaction Hash from a Transaction Body from a Transaction Builder:
Signing a Transaction or Adding a Signature: