Use early return when repsonse is empty

EmicoEcommerce · Jan 16, 2025 · 63da07c · 63da07c
1 parent 4356dda
commit 63da07c
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/Model/Config/Source/Template.php b/Model/Config/Source/Template.php
@@ -56,10 +56,12 @@ protected function buildOptions()
             ['value' => null, 'label' => __('* Default template')],
         ];
 
-        if (!empty($response->getTemplates())) {
-            foreach ($response->getTemplates() as $template) {
-                $result[] = ['value' => $template->getTemplateId(), 'label' => $template->getName()];
-            }
+        if (!is_array($response->getTemplates())) {
+            return $result;
+        }
+
+        foreach ($response->getTemplates() as $template) {
+            $result[] = ['value' => $template->getTemplateId(), 'label' => $template->getName()];
         }
 
         return $result;