Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore and no_run to get cargo test to pass. #1101

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

LegNeato
Copy link
Contributor

Without these running cargo test on a clean checkout fails.

@LegNeato LegNeato requested a review from eddyb as a code owner November 27, 2023 02:11
Copy link
Contributor

@eddyb eddyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can you add a CHANGELOG entry, and also make sure we run all the tests on CI, so this gets hit?

Ideally you could do it in a commit before the fixes, and push that commit first, such that we can see CI fail before the fix (so we know the CI changes can reproduce).

@LegNeato
Copy link
Contributor Author

@eddyb done. I debated using --doc and/or using -p on each of the crates instead of doing the entire cargo test, but this was the "safest" as it would catch any issues.

@LegNeato LegNeato requested a review from eddyb December 17, 2023 21:15
@fornwall fornwall requested review from fornwall and removed request for eddyb January 24, 2024 11:55
Copy link
Contributor

@fornwall fornwall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fornwall fornwall enabled auto-merge (squash) January 24, 2024 11:55
@fornwall fornwall merged commit f955221 into EmbarkStudios:main Jan 24, 2024
7 checks passed
@LegNeato LegNeato deleted the doc_failure branch January 24, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants