rpmalloc-sys: Update rpmalloc submodule to latest upstream branch
#24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This submodule was originally pointing to a commit somewhere between the 1.4.3 and 1.4.4 release (at the time this Rust wrapper was last committed to). Note that the upstream `main` branch is slightly ahead of the latest 1.4.5 release, because it also includes a just-merged fix for using Android API level 29+ compiled with LLVM 17+, which Rust apps would otherwise fail to load at runtime. The 1.4.5 release already contains a fix for ARM64 Windows, which is equally of interest to us. Finally, also add a `rerun-if-changed` on the `rpmalloc.c` file, so that **local** submodule changes and experimentations actually cause the crate to be recompiled. `cc-rs` only emits these for the environment variables, but not for `.file()` arguments.
This was referenced Mar 12, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
This submodule was originally pointing to a commit somewhere between the 1.4.3 and 1.4.4 release (at the time this Rust wrapper was last committed to). Note that the upstream
mainbranch is slightly ahead of the latest 1.4.5 release, because it also includes a just-merged fix for using Android API level 29+ compiled with LLVM 17+, which Rust apps would otherwise fail to load at runtime. The 1.4.5 release already contains a fix for ARM64 Windows, which is equally of interest to us.Finally, also add a
rerun-if-changedon therpmalloc.cfile, so that local submodule changes and experimentations actually cause the crate to be recompiled.cc-rsonly emits these for the environment variables, but not for.file()arguments.