Release version 0.19.0
#85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fornwall
requested review from
Jake-Shadle and
fu5ha
and removed request for
VZout
MarijnS95
reviewed
Apr 3, 2024
| @@ -64,6 +68,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| <!-- next-url --> | |||
| [Unreleased]: https://github.com/EmbarkStudios/ash-molten/compare/0.18.0...HEAD | |||
There was a problem hiding this comment.
Suggested change
| [Unreleased]: https://github.com/EmbarkStudios/ash-molten/compare/0.18.0...HEAD | |
| [Unreleased]: https://github.com/EmbarkStudios/ash-molten/compare/0.19.0...HEAD |
There was a problem hiding this comment.
Thanks! Created #86 for that.
MarijnS95
reviewed
Apr 3, 2024
| [advisories] | ||
| ignore = [ | ||
| # Unmtaintained `safemem` dependency - only used by plist to build | ||
| "RUSTSEC-2023-0081", |
There was a problem hiding this comment.
Should the CI have checked against unused advisories?
There was a problem hiding this comment.
Would be nice if cargo-deny did that, but I don't think it supports that now.
There was a problem hiding this comment.
I'm pretty sure we've set up cargo-deny such that it warns on allowed/ignored things that are no longer triggered in the first place (both for advisories as well as skipping crates).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release
0.19containing the update toashversion0.38as the only change: #83