Avoid creating traversers for empty lists #29

Embarcadero · Dec 7, 2024 · b05dd6d · b05dd6d
1 parent 36f2ca1
commit b05dd6d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/Source/BoldLockRegions.pas b/Source/BoldLockRegions.pas
@@ -485,8 +485,9 @@ procedure TBoldRegionLookup.AddRegionLookup(Regions: TBoldRegionLookup);
 var
   Region: TBoldRegion;
 begin
-  for Region in Regions do
-    AddIfNotInLookup(Region);
+  if not Regions.IsEmpty then
+    for Region in Regions do
+      AddIfNotInLookup(Region);
 end;
 
 constructor TBoldRegionLookup.Create;

diff --git a/Source/BoldOptimisticLockingSupport.pas b/Source/BoldOptimisticLockingSupport.pas
@@ -177,6 +177,8 @@ procedure TBoldOptimisticLockHandler.GetLockingValuesForRegions(Regions: TBoldRe
 var
   Traverser: TBoldIndexableListTraverser;
 begin
+  if Regions.IsEmpty then
+    exit;
   Traverser := Regions.CreateTraverser;
   while Traverser.MoveNext do
   begin
@@ -446,6 +448,8 @@ procedure TBoldOptimisticLockHandler.AddRegionsObjectsToEnclosure(
 var
   Traverser: TBoldIndexableListTraverser;
 begin
+  if Regions.IsEmpty then
+    exit;
   Traverser := Regions.CreateTraverser;
   while Traverser.MoveNext do
   begin