2025-01-24 Fred Gleason <[email protected]>

* Fixed a bug in the WebGet service that caused uploads to fail when using an Apache package with 'PrivateTmp=true' set in it's Systemd service definition. Signed-off-by: Fred Gleason <[email protected]>
ElvishArtisan · Jan 24, 2025 · 1fc728d · 1fc728d
1 parent 8f1b9d6
commit 1fc728d
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/ChangeLog b/ChangeLog
@@ -24950,3 +24950,7 @@
 2025-01-23 Fred Gleason <[email protected]>
 	* Fixed a bug in 'RDPam' that could cause a segfault when processing
 	an authentication.
+2025-01-24 Fred Gleason <[email protected]>
+	* Fixed a bug in the WebGet service that caused uploads to fail when
+	using an Apache package with 'PrivateTmp=true' set in it's Systemd
+	service definition.
diff --git a/lib/rdformpost.cpp b/lib/rdformpost.cpp
@@ -96,6 +96,10 @@ RDFormPost::RDFormPost(RDFormPost::Encoding encoding,bool auto_delete)
     post_error=RDFormPost::ErrorNoTempDir;
     return;
   }
+  if(chmod(post_tempdir->path().toUtf8(),0755)!=0) {
+    post_error=RDFormPost::ErrorNoTempDir;
+    return;
+  }
 
   //
   // (Perhaps) autodetect the encoding type
@@ -746,7 +750,8 @@ bool RDFormPost::GetMimePart(QString *name,QString *value,bool *is_file,
 	    }
 	    if(f2[0]=="filename") {
 	      *value=post_tempdir->path()+"/"+f2[1].replace("\"","");
-	      fd=open(value->toUtf8(),O_WRONLY|O_CREAT,S_IRUSR|S_IWUSR);
+	      fd=open(value->toUtf8(),O_WRONLY|O_CREAT,
+		      S_IRUSR|S_IWUSR|S_IRGRP|S_IROTH);
 	      *is_file=true;
 	    }
 	  }

diff --git a/systemd/rivendell.service.in b/systemd/rivendell.service.in
@@ -9,7 +9,8 @@ LimitNOFILE=4096
 Type=simple
 ExecStart=@prefix@/sbin/rdservice
 Environment=JACK_PROMISCUOUS_SERVER=audio
-PrivateTmp=false
+PrivateTmp=true
+JoinsNamespaceOf=@APACHE_PKG@
 Restart=always
 RestartSec=2
 StartLimitInterval=120