Update MSYS2 job in GitHub Actions workflow #496
Conversation
- Create new 'windows-mingw' job in build.yaml - Set up MSYS2 environment using msys2/setup-msys2 action - Install necessary packages including MinGW-w64 GCC, Fortran, CMake - Configure build with MSYS Makefiles generator - Build and run quick tests This change improves Windows support by enabling builds with MSYS2 Mingw-w64, making Elmer more accessible to Windows users without WSL or admin rights. relevant to #494
- Remove unavailable mingw-w64-x86_64-openmpi package - Disable MPI in CMake configuration This change allows the MSYS2 Mingw-w64 build to proceed without errors, though it disables MPI support. Future work may be needed to re-enable MPI using an alternative package or build method. relevant to #494
.github/workflows/build.yaml
Outdated
| mingw-w64-x86_64-cmake | ||
| mingw-w64-x86_64-openblas | ||
| mingw-w64-x86_64-parmetis | ||
| make |
There was a problem hiding this comment.
It'd probably be a good idea to install the base-devel group instead of only make.
There was a problem hiding this comment.
@mmuetzel thanks for the comment. Do you want to share a patch or send a PR to this specific branch? I think it should be possible to give you write access to this specific branch. But I rather core devs to do that.
There was a problem hiding this comment.
Why can't you make that change yourself? It shouldn't be hard.
There was a problem hiding this comment.
@mmuetzel fair point. But I did not explain myself properly. Given your experience it would be great if we could give you write access on some of the MSYS2 / Mingw-w64 / Windows-related branches. Of course, if you are interested.
Improve MSYS2 setup in GitHub Actions workflow - Replace 'make' with 'base-devel' group in package installation - This change provides a more comprehensive set of development tools, including make and other essential utilities for building
.github/workflows/build.yaml
Outdated
| -DWITH_Zoltan=OFF \ | ||
| -DWITH_Mumps=OFF \ | ||
| -DCREATE_PKGCONFIG_FILE=ON \ | ||
| -DWITH_MPI=ON |
There was a problem hiding this comment.
I accidentally commented on the commit instead of on the PR. So, repeating here. Sorry for the noise.
| -DWITH_MPI=ON | |
| -DWITH_MPI=ON \ | |
| -DMPIEXEC_EXECUTABLE="C:/Program Files/Microsoft MPI/Bin/mpiexec.exe" \ |
But for this to actually pass in CI, you'd need a new step to install MSMPI.
To install it locally, you can get the installer from here: https://www.microsoft.com/en-us/download/details.aspx?id=105289 (The MS server seems to be down currently.)
I haven't looked into how that could be installed in CI though...
PS: In any case, you are missing a line continuation here.
Foadsf
force-pushed
the
feat/windows-msys2-build
branch
from
132ae9b
to
712d123
Compare
|
I hard reset the latest two commits on the |
If you wait for another day or two, you'll no longer need these Fortran flags. MSYS2 should have updated the |
|
Do you know why this PR triggers the action four times each time you push a change?
One is probably because it triggers on a push on your branch, the other one is for the pull request (i.e., for a merge to the base branch). P.S. by Foad follow-up discussions here on Discord. |
|
Great developmemts! I wonder if this would deserve its own .yaml file? See the comment here: #487 (comment) |
|
The content of this PR has been manually copied to here: The build action can be seen here: |
|
Closing this one as the msys2 build is now successfully in the CI. |
This change allows the MSYS2 Mingw-w64 build to proceed without
errors, though it disables MPI support. Future work may be needed
to re-enable MPI using an alternative package or build method.
relevant to #494