Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip .json extension from URLs returned from API endpoints #998

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

fbacall
Copy link
Member

@fbacall fbacall commented Jul 16, 2024

Summary of changes

  • Remove the .json extension from resource URLs in API responses

Motivation and context

Because these are used in various autocompleters (e.g. when adding a material to a collection), and can end up taking a web user to a JSON page.

API clients can get JSON using the Accept header.

Checklist

  • I have read and followed the CONTRIBUTING guide.
  • I confirm that I have the authority necessary to make this contribution on behalf of its copyright owner and agree
    to license it to the TeSS codebase under the
    BSD license.

They are used to render snippets in the UI
@fbacall fbacall merged commit debd784 into master Jul 18, 2024
11 checks passed
@fbacall fbacall deleted the remove-json-ext branch July 18, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant