Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ORCID + HTTP URL validators #884

Merged
merged 5 commits into from
Aug 23, 2023
Merged

Improve ORCID + HTTP URL validators #884

merged 5 commits into from
Aug 23, 2023

Conversation

fbacall
Copy link
Member

@fbacall fbacall commented Aug 22, 2023

Summary of changes

  • Validate ORCID is actually a valid ID (using checkbit).
  • Don't validate ORCID by checking URL is accessible.
  • Safer HTTP URL validation.
  • Fix WebMock registry not being cleared between tests, leading to test slowdown.
  • Add minitest-reporters to catch slow tests.

Motivation and context

Checklist

  • I have read and followed the CONTRIBUTING guide.
  • I confirm that I have the authority necessary to make this contribution on behalf of its copyright owner and agree
    to license it to the TeSS codebase under the
    BSD license.

@fbacall fbacall merged commit 6358710 into master Aug 23, 2023
11 checks passed
@fbacall fbacall deleted the validate-orcid branch August 23, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant