Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the sort options go through i18n. #1025

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cwant
Copy link
Contributor

@cwant cwant commented Sep 18, 2024

Summary of changes

The strings used in the sort options for search now go through i18n.

Motivation and context

As has come up elsewhere, a Canadian fork for TeSS is striving to make an English/French bilingual instance. There are many places in the TeSS code base where strings in the view don't go through i18n. This PR just handles just the sort options for searching. (Note: I think it might be better to send these improvements in smaller atomic PRs rather than in one mega-PR.)

Screenshots

Looks the same as before.

Checklist

  • I have read and followed the CONTRIBUTING guide.
  • I confirm that I have the authority necessary to make this contribution on behalf of its copyright owner and agree
    to license it to the TeSS codebase under the
    BSD license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant