-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Learning paths docs #1007
Learning paths docs #1007
Conversation
catch up to head
Add ingestor for Carpentries workshop feeds
Not fully tested the sidebar in adding learning path or topics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few small changes
@@ -3,7 +3,7 @@ | |||
</div> | |||
<div class="row"> | |||
<div class="col-md-4 col-md-push-8"> | |||
<%# render :partial => "learning_paths/partials/general_learning_path_info" %> | |||
<% render :partial => "learning_paths/partials/general_learning_path_info" %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to start with <%=
config/locales/en.yml
Outdated
For example, learning paths from the ELIXIR community will follow the protocol created by the | ||
ELIXIR Training Platform/Learning Paths Focus Group.</li></ul> | ||
<p>Governance: Maintaining the learning path</p> | ||
<ol><li>It is the responsibility of the learning path curator to maintain their community»s learning paths.</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
config/locales/en.yml
Outdated
learning path to add them to a list. You can view your starred resources later by clicking the user icon | ||
at the top-right of the screen then 'My stars'. To use the star feature you need to be a registered TeSS user.</li> | ||
view_topics: > | ||
<ol><li>On the 'Learning paths' tab, click the 'Topics' button at the top-right.</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to mention in the original doc, but this button is actually labelled "Manage Topics" in the latest version of TeSS (not deployed yet)
config/locales/en.yml
Outdated
[email protected] to request permission.</p> | ||
<p>The three steps to register a learning path are described in full detail below.</p> | ||
training_material: > | ||
<p>To <a href='about/registering'>register training materials follow the instructions here</a>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the link here its better to let Rails generate the correct path. You can do it like we did here:
TeSS/app/views/about/tess.html.erb
Line 105 in 1e2efc7
<p><%== t('about.subscription_manager', subscriptions_path: subscriptions_path) %></p> |
in this case it would be registering_resources_path
@@ -3,7 +3,7 @@ | |||
</div> | |||
<div class="row"> | |||
<div class="col-md-4 col-md-push-8"> | |||
<%# render :partial => "learning_paths/partials/general_learning_path_info" %> | |||
<% render :partial => "learning_path_topics/partials/general_learning_path_topic_info" %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to start with <%=
to appear on the page
Summary of changes
Motivation and context
Screenshots
Checklist
to license it to the TeSS codebase under the
BSD license.