Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to cookie_store for sessions #1000

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

fbacall
Copy link
Member

@fbacall fbacall commented Jul 16, 2024

Summary of changes

  • Store session data in encrypted cookies instead of a database table.

Motivation and context

The sessions table in production accounts for 90%+ of the database size even when pruned of stale sessions. This table is written to every time an anonymous user visits TeSS. It's not clear why we moved away from the default cookie store implementation in the first place as we are not storing much data in the session.

Checklist

  • I have read and followed the CONTRIBUTING guide.
  • I confirm that I have the authority necessary to make this contribution on behalf of its copyright owner and agree
    to license it to the TeSS codebase under the
    BSD license.

Storing in database results in a giant table that needs pruning etc.
@fbacall fbacall merged commit 9d546ed into master Aug 1, 2024
11 checks passed
@fbacall fbacall deleted the switch-cookie-store branch August 1, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant