-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added colons #2
base: main
Are you sure you want to change the base?
Added colons #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are some concerns with this code, generally. Not the semicolons, those are fine.
|
||
const trackingExtensions = [ | ||
'Gruntfuggly.todo-tree', | ||
'ezrafree.markdown-preview', | ||
'bierner.markdown-checkbox' | ||
] | ||
]; | ||
|
||
const installExtensions = async (includeTracking) => { | ||
console.group('Installing extensions...') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be console.log
@@ -4,13 +4,13 @@ const extensions = [ | |||
'SpeedyLom.dislexic-vscode', | |||
'streetsidesoftware.code-spell-checker', | |||
'vscode-icons-team.vscode-icons' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a comma after every item
@@ -27,5 +27,5 @@ const installExtensions = async (includeTracking) => { | |||
})) | |||
console.log('✅ Extensions installed') | |||
console.groupEnd() | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing whitespace.
We've changed our code convention to include semicolons, so I've added them in four places.