Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only import required lodash methods to reduce bundle size #175

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cvbuelow
Copy link

No description provided.

@joealden
Copy link

Would resolve #118.

@Eliav2 with v3 being abandoned (for now at least), and for how little time this would take to merge + release, could we please get this in as a 2.x.x release? Would be very much appreciated!

@Eliav2
Copy link
Owner

Eliav2 commented Feb 19, 2024

Sorry can't merge it for now because can't test it without setting up an proper environment.
What is the reason you still using this lib in 2024? Seriously, there is no better alternative this day?

@joealden
Copy link

joealden commented Feb 19, 2024

@Eliav2 I had a good look around when I introduced your lib to my work's codebase, and couldn't find anything as good that satisfied these points:

  • Ref based connections - a lot of other libs are id or class based, which isn't as ergonomic when we're wanting to render lines dynamically.
  • Grid based connections.
  • Something simple - we just use it to connect static elements in a UI (as well as moving things along these paths sometimes), we don't need or want all that comes with react-flow.

I had a look around again this weekend after I saw the deprecation notice, and still couldn't find anything that was as elegant. Today I tried implementing something custom within our codebase, but struggled with positioning, re-rendering, etc. I also tried patching your lib via yarn patch to peform the changes in this PR, but ran into problems due to the library being published to NPM already built via webpack.

I appreciate that it's a niche case!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants