Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add pirate-speak translation #113

Closed

Conversation

kd8lvt
Copy link
Contributor

@kd8lvt kd8lvt commented Jan 30, 2024

Ahoy, landlubbers!
Me and me crew 'ave decided ta' set sail on 'n adventure nobody asked fer or wanted, ta' make lingo providers fer each of ta' meme lingos 'n Minecraft. Ta' first I took on be Pirate Speak.
'Tis not a full translation, fer ta' way ta' Advancements n' Guidebook Providers 'ave been written means I've no inklin' how ta' translate 'em on ta' fly. 'Owever, everythin' else aside fer Flag Patterns (as they be scurvy dogs who be stubbornly avoidin' me translatin') 'ave been fully translated.


Heyo!
I've decided to take on a task nobody asked for or wanted - making LanguageProviders for each of the meme languages in Minecraft. I started with Pirate Speak, as it is freakin' hilarious.
It's not a full translation, as the way the AdvancementProvider and GuidebookProvider are written means I have no idea how to translate them dynamically. Everything else (besides Banner Patterns - they're being stubborn) have been fully translated.

@Elenterius
Copy link
Owner

Elenterius commented Jan 31, 2024

please change your commit message to something like this: feat: add Pirate-speak lingo

@kd8lvt kd8lvt changed the title Avast! Pirate Speak lingo be mostly finished. feat: Add pirate-speak translation Jan 31, 2024
@kd8lvt
Copy link
Contributor Author

kd8lvt commented Jan 31, 2024

Aye, capn'. I've done as ye' requested, as much as ye' be woundin' me very soul.


Done, as much as it hurts my inner pirate :P

@kd8lvt
Copy link
Contributor Author

kd8lvt commented Jan 31, 2024

Wait, no how do I change the commit name? Hold on...

@kd8lvt kd8lvt closed this Jan 31, 2024
@kd8lvt kd8lvt deleted the mc.20.1/joke_translations branch January 31, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants