Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added logging to max fee limits amounts for swaps #62

Merged
merged 1 commit into from
Nov 18, 2023
Merged

Added logging to max fee limits amounts for swaps #62

merged 1 commit into from
Nov 18, 2023

Conversation

Jossec101
Copy link
Contributor

@Jossec101 Jossec101 commented Nov 17, 2023 •
edited
Loading

  • fix(loop_provider.go): handle error when parsing LIMITFEES environment variable to prevent potential panic
  • refactor(loop_provider.go): introduce maximumFeesAllowed variable for better code readability
  • feat(loop_provider.go): enhance error message when swap fees exceed maximum limit fees to provide more detailed information

@Jossec101
fix(loop_provider.go): handle error when parsing LIMITFEES environmen…
3a5632c 
…t variable to prevent potential panic

refactor(loop_provider.go): introduce maximumFeesAllowed variable for better code readability
feat(loop_provider.go): enhance error message when swap fees exceed maximum limit fees to provide more detailed information
@Jossec101 Jossec101 changed the title fix(loop_provider.go): handle error when parsing LIMITFEES environment variable to prevent potential panic refactor(loop_provider.go): introduce maximumFeesAllowed variable for better code readability feat(loop_provider.go): enhance error message when swap fees exceed maximum limit fees to provide more detailed information Added logging to max fee limits amounts for swaps Nov 17, 2023
@Jossec101 Jossec101 merged commit c83672c into main Nov 18, 2023
1 check passed
@Jossec101 Jossec101 deleted the added-loggin-fee-limit branch November 18, 2023 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markettes markettes markettes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jossec101 @markettes