-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data model for freezing UTXOs #376
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
markettes
commented
Jun 25, 2024
•
edited
Loading
edited
- Adds isFrozen and address to be used in the FMUTXOs
- Adds tags to FMUTXOs
- Adds a job to register all the new utxos in the system
…ased on channel and withdrawal statuses
…el enhancements feat(FMUTXO.cs): implement Equals method for UTXO comparison with NBitcoin types refactor(RegisterUTXOsJob.cs): adjust equality check to use modified Equals method in FMUTXO model for clarity and consistency
… parameter to constructor calls to align with updated constructor signature
…is was giving a race condition when generating the db (#375)
…il to recognize the entities when saving a list
refactor(FMUTXO.cs): improve IsSpent property logic to handle null collections feat(FUTXORepository.cs): include Tags in FMUTXOs query to provide more detailed data
…e performance and accuracy feat(RegisterUTXOsJob.cs): log information after adding new UTXOs to enhance traceability fix(Constants.cs, launchSettings.json): align REGISTER_UTXOS_CRON schedule across configurations for consistency
markettes
requested review from
Jossec101 and
RodriFS
and removed request for
Jossec101
June 25, 2024 15:41
markettes
commented
Jun 25, 2024
…clean up code refactor(FMUTXO.cs): remove redundant Equals method that compares UTXO objects, simplifying the model
… UTXOTag from FMUTXO model
…nt method WHY: Enhance querying capabilities by allowing retrieval of UTXOTag based on both key and outpoint, facilitating more specific data access patterns.
…a integrity refactor(IUTXOTagRepository): rename GetTagByKeyAndOutpoint to GetByKeyAndOutpoint for consistency feat(IUTXOTagRepository): add GetByKeyValue method to query UTXOTags by key and value
…structors for consistency refactor(BitcoinServiceTests.cs): add missing null parameter in CoinSelectionService constructor for completeness
RodriFS
previously approved these changes
Jun 28, 2024
RodriFS
previously approved these changes
Jun 28, 2024
Jossec101
reviewed
Jul 1, 2024
Jossec101
previously approved these changes
Jul 1, 2024
Co-authored-by: José A.P <[email protected]>
Jossec101
approved these changes
Jul 1, 2024
RodriFS
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.