-
Notifications
You must be signed in to change notification settings - Fork 941
docs: Update install docs for v25.02 #8204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update install docs for v25.02 #8204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 3128fd3
Also removes usage of pip due to this error that crops up on newer versions of Ubuntu: ``` error: externally-managed-environment × This environment is externally managed ╰─> To install Python packages system-wide, try apt install python3-xyz, where xyz is the package you are trying to install. If you wish to install a non-Debian-packaged Python package, create a virtual environment using python3 -m venv path/to/venv. Then use path/to/venv/bin/python and path/to/venv/bin/pip. Make sure you have python3-full installed. If you wish to install a non-Debian packaged Python application, it may be easiest to use pipx install xyz, which will manage a virtual environment for you. Make sure you have pipx installed. See /usr/share/doc/python3.12/README.venv for more information. note: If you believe this is a mistake, please contact your Python installation or OS distribution provider. You can override this, at the risk of breaking your Python installation or OS, by passing --break-system-packages. hint: See PEP 668 for the detailed specification. ``` I've been recommending installing Poetry from the official installer for the past several months and it always works. Changelog-None
3128fd3
to
07c9c8e
Compare
rebased on master @ShahanaFarooqui this is ready for re-review! related: #8161 |
@daywalker90 @ZenenTreadwell would love an ACK here :) |
ACK 07c9c8e I am ambivalent about poetry as a package manager - I much prefer using the standard venv package - but seeing as it is already integrated into CLN's installation process, I think that having it properly documented is a good thing. +1 to everything else for improving readability and keeping things updated |
I think it's also time to clean up the |
@endothermicdev thanks for the review! Are you planning to make the mentioned edits to the |
I can do that in another PR. |
Also removes usage of pip due to this error that crops up on newer versions of Ubuntu:
I've been recommending installing Poetry from the official installer for the past several months and it always works.
Changelog-None
Important
25.02 FREEZE JANUARY 31ST: Non-bugfix PRs not ready by this date will wait for 25.05.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked: