-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Candidate 1.3.0 release #455
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgriffiths
force-pushed
the
bip32_key_tweak
branch
from
July 8, 2024 02:48
1ddd1b4
to
a6bf2a1
Compare
jgriffiths
force-pushed
the
bip32_key_tweak
branch
from
July 15, 2024 19:25
a6bf2a1
to
6afd6e8
Compare
We only need to check the end condition initially, and can then avoid it while analyzing the rest of the tx.
- Ensure the resulting tweak is zero if a tweak is not asked for - Make deriving from private keys into public keys apply the tweak - Make bip32_key_from_parent and not just bip32_key_from_parent_path apply the tweak.
jgriffiths
force-pushed
the
bip32_key_tweak
branch
from
July 19, 2024 04:29
6afd6e8
to
f9a771f
Compare
Includes support for optimized single signature recovery signing.
jgriffiths
force-pushed
the
bip32_key_tweak
branch
from
July 19, 2024 04:59
f9a771f
to
11e1bf6
Compare
jgriffiths
changed the title
bip32: fix Elements pubkey tweaking
Candidate 1.3.0 release
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elements key tweak, cmake and PSBT fixes, new script helper.