mbed_tls: don't byteswap if HW acceleration is already big endian #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgriffiths
reviewed
Nov 8, 2023
greenaddress
force-pushed
the
mbedtls_fixes
branch
from
5789ecf to
47d9161
Compare
Tested on:
esp32:
- vanilla wally without mbed
- wally with mbed with acceleration off
- wally with mbed with acceleration on
esp32s3:
- vanilla wally without mbed
- wally with mbed with acceleration off
- wally with mbed with acceleration on
should also work on esp32s2, esp32c3, esp32c6, esp32p4, etc
Please note:
There's 4 implementations: software, parallel engine, block engine, dma
SOC_SHA_SUPPORT_PARALLEL_ENG is only defined for esp32.
esp32s3 uses DMA
SOC_SHA_ENDIANNESS_BE is not available in release branches, only in master and only for esp32 AFAIK
example of how idf checks for things https://github.com/espressif/esp-idf/blob/master/components/mbedtls/port/sha/esp_sha.c#L19
We depend on `#include <soc/soc_caps.h>` to get SOC_SHA_SUPPORT_PARALLEL_ENG (which wasn't available to wally before!!!)
and we depend on `#include <sdkconfig.h> to get CONFIG_MBEDTLS_HARDWARE_SHA which is necessary to distinguish between mbedtls with or without hw acceleration.
instead of including sdkconfig.h (and or soc_caps.h) we could have other flags like `HAVE_MBEDTLS_SHA256_H` and `HAVE_MBEDTLS_SHA512_H`
esp32 -> requires the `cpu_to_be32` steps with both software and hardware sha
esp32s3 -> requires `cpu_to_be32` only for software, for hardware the memcpy is enough
`SOC_SHA_SUPPORT_PARALLEL_ENG` is defined only for esp32
`SOC_SHA_ENDIANNESS_BE` is defined only for esp32 but only in master and unreleased yet in a stable release.
`SOC_SHA_SUPPORT_DMA` is defined for esp32s3 (and esp32s2)
greenaddress
force-pushed
the
mbedtls_fixes
branch
from
47d9161 to
a8d0b53
Compare
|
Merged with README tweaks, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on:
esp32:
esp32s3:
should also work on esp32s2, esp32c3, esp32c6, esp32p4, etc
Please note:
There's 4 implementations: software, parallel engine, block engine, dma
SOC_SHA_SUPPORT_PARALLEL_ENG is only defined for esp32. esp32s3 uses DMA
SOC_SHA_ENDIANNESS_BE is not available in release branches, only in master and only for esp32 AFAIK
example of how idf checks for things https://github.com/espressif/esp-idf/blob/master/components/mbedtls/port/sha/esp_sha.c#L19
We depend on
#include <soc/soc_caps.h>to get SOC_SHA_SUPPORT_PARALLEL_ENG (which wasn't available to wally before!!!) and we depend on `#include <sdkconfig.h> to get CONFIG_MBEDTLS_HARDWARE_SHA which is necessary to distinguish between mbedtls with or without hw acceleration.instead of including sdkconfig.h (and or soc_caps.h) we could have other flags like
HAVE_MBEDTLS_SHA256_HandHAVE_MBEDTLS_SHA512_H