Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python/CI build fixes #430

Merged
merged 7 commits into from
Nov 8, 2023
Merged

Python/CI build fixes #430

merged 7 commits into from
Nov 8, 2023

Conversation

jgriffiths
Copy link
Contributor

@jgriffiths jgriffiths commented Nov 5, 2023

More build work for v1.0.

  • Support standard build methods python -m build and pip install ..
  • Build and validate an sdist package for PyPI uploads.
  • Resurrect the internal CI, add test and valgrind runs.

Fixes #332

Verified

This commit was signed with the committer’s verified signature.
Sync libsecp256k1-zkp if it is not present, and update MANIFEST.in to
allow building wheels from the sdist (subject to the box having the
required build tools present).

Verified

This commit was signed with the committer’s verified signature.
wally wheels should be built using standard tools, e.g.

'build': 'python -m build" to build an sdist and then build a wheel for that sdist.
'pip': 'pip install .' to build a wheel and install it.

Now that standard builds are supported, update the internal CI
docker image/config to build an isolated wheel from its sdist and
smoke test it. The tested sdist can then be uploaded to PyPI to
enable pip installs for systems we don't provide binaries for.
@jgriffiths jgriffiths force-pushed the yet_more_build_fixes branch from 36d3917 to 60e6197 Compare November 5, 2023 11:06

Verified

This commit was signed with the committer’s verified signature.
Makes npm builds much faster/less bandwitdh intensive.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
@jgriffiths jgriffiths force-pushed the yet_more_build_fixes branch from c33c721 to d331e1f Compare November 6, 2023 00:37
@jgriffiths jgriffiths changed the title Python build fixes Python/CI build fixes Nov 6, 2023
@jgriffiths jgriffiths force-pushed the yet_more_build_fixes branch from d331e1f to 291d169 Compare November 6, 2023 07:47

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
@jgriffiths jgriffiths force-pushed the yet_more_build_fixes branch from 291d169 to 88cbaa0 Compare November 8, 2023 05:59
@jgriffiths jgriffiths merged commit 88cbaa0 into master Nov 8, 2023
@jgriffiths jgriffiths deleted the yet_more_build_fixes branch November 8, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No source-disribution for python pip for 0.8.4 and 0.8.5
1 participant