Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the new website design from ElementalCode/elemental#220 #233

Merged
merged 4 commits into from
Jul 27, 2016
Merged

use the new website design from ElementalCode/elemental#220 #233

merged 4 commits into from
Jul 27, 2016

Conversation

mrjacobbloom
Copy link
Contributor

@mrjacobbloom mrjacobbloom commented Jul 23, 2016

I haven't done any of the logged-in stuff yet 'cause I'm having trouble registering a new account on localhost. But I broke down the HTML into navbar/index/footer/etc. and tried to do the same for the SASS, and I updated the login and signup pages.

@mrjacobbloom
Copy link
Contributor Author

see #220


/* == Logged out user things == */
// Is it possible to only serve these when the user is logged out?
#logged-out-header {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use classes instead of IDs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@matthewr6
Copy link
Contributor

matthewr6 commented Jul 23, 2016

Other than the comment above, it looks good

@mrjacobbloom
Copy link
Contributor Author

There's still a lot of stuff in style.scss that might not be used--I haven't checked

@mrjacobbloom
Copy link
Contributor Author

Is there anything else you want added before merging this?

@matthewr6
Copy link
Contributor

I just forgot to merge it, oops

@matthewr6 matthewr6 merged commit 27999b0 into ElementalCode:master Jul 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants