Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

Scraper: Error message of missing csv files now contains file name #1303

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

chr-schr
Copy link
Contributor

@chr-schr chr-schr commented Apr 18, 2024

Scraper: Error message of missing csv files now contains the file name

Closes #1242

Example log:

> [email protected] insert
> npm run insert:plants && npm run insert:relations

> [email protected] insert:plants
> node src/insert_plants.js

[INFO] Starting the insertion of plants into database.
[ERROR] Error reading CSV file 'data/finalDataset.csv': Error: File does not exist. Check to make sure the file path to your csv is correct.

Basics

  • The PR is rebased with current master
  • I added a line to changelog.md
  • Details of what I changed are in the commit messages
  • References to issues, e.g. close #X, are in the commit messages and changelog
  • The buildserver is happy

Checklist

  • I fully described what my PR does in the documentation
  • I fixed all affected documentation
  • I fixed the introduction tour
  • I wrote migrations in a way that they are compatible with already present data
  • I fixed all affected decisions
  • I added automated tests or a manual test protocol
  • I added code comments, logging, and assertions as appropriate
  • I translated all strings visible to the user
  • I mentioned every code or binary not directly written or done by me in reuse syntax
  • I created left-over issues for things that are still to be done
  • Code is conforming to our Architecture
  • Code is conforming to our Guidelines
  • Code is consistent to our Design Decisions
  • Exceptions to any guidelines are documented

First Time Checklist

Review

  • I've tested the code
  • I've read through the whole code
  • I've read through the whole documentation
  • I've checked conformity to guidelines
  • I've checked conformity to requirements
  • I've checked that the requirements are tested

@chr-schr chr-schr linked an issue Apr 18, 2024 that may be closed by this pull request
@chr-schr chr-schr added the please review Review by unspecified person requested label Apr 18, 2024
Copy link
Contributor

@markus2330 markus2330 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and elegant solution. 👍

CI fails, though.

@markus2330
Copy link
Contributor

jenkins build please

@chr-schr
Copy link
Contributor Author

jenkins build please

@chr-schr chr-schr mentioned this pull request Apr 21, 2024
@markus2330
Copy link
Contributor

jenkins build please

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
please review Review by unspecified person requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error message of scraper should contain file name
3 participants