This repository has been archived by the owner on Apr 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 13
Return 409 conflict when POST /maps with taken name. close #758 #1298
Open
horenso
wants to merge
1
commit into
master
Choose a base branch
from
feature/horenso/758-conflict-on-new-map-with-taken-name
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Return 409 conflict when POST /maps with taken name. close #758 #1298
horenso
wants to merge
1
commit into
master
from
feature/horenso/758-conflict-on-new-map-with-taken-name
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenkins build please |
markus2330
suggested changes
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! CI did not run through and not enough reviews here yet, though.
chr-schr
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me for the backend 👍
But the frontend should display the specific error message instead of a generic one.
I suggest to update #758 and add a frontend task or create a left over issue.
- I've tested the code
- I've read through the whole code
- I've read through the whole documentation
- I've checked conformity to guidelines
- I've checked conformity to requirements
- I've checked that the requirements are tested
jenkins build please |
Closed
horenso
force-pushed
the
feature/horenso/758-conflict-on-new-map-with-taken-name
branch
from
April 22, 2024 21:49
c180740
to
886a9c4
Compare
horenso
requested review from
markus2330 and
danielsteinkogler
and removed request for
badnames
April 23, 2024 20:09
danielsteinkogler
approved these changes
Apr 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Return 409 conflict when creating a new map with existing name instead of a 500 server error.
Also add a simple regression test.
Basics
close #X
, are in the commit messages and changelogChecklist
First Time Checklist
Review