fix: Conversion to use ImageSharp rather than System.Drawing.Common #880
+1,557
−987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry pick of 86644e7. See PR ElectronNET#637 for details
Eliminate warning CS4014 by explicitly discarding the returned Task by assigning it to `_`.
Refactor the Init and Start commands: - Use MSBuild to get certain project properties. - Use XML tools to read and manipulate XML files. - Use JSON tools to read and manipulate JSON files. - Include and deploy package-lock.json. - Pay close attention to all paths and try to avoid making path assumptions. - Use npm (npx) to launch electron. Refactors `ProcessHelpers` to use `CliWrap` library for more robust command execution (argument escaping primarily). > Note: We currently need to use an older version of the library since the bleeding edge no longer supports .NET 6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Socket.Emitby assigning it to_.UpdateUpdate: CICD requires VS2017 (v15) so at this point we cannot update to VS2022.src/ElectronNET.slnto VS2022 (v17). VSCode's C# Dev Kit extension doesn't seem to like v15.