Skip to content

fix: Conversion to use ImageSharp rather than System.Drawing.Common #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

mrfootoyou
Copy link

@mrfootoyou mrfootoyou commented Jun 8, 2025

  • Cherry pick of 86644e7 by @danatcofo. See PR System.Drawing.Common is targeted at Windows only #637 for details
  • Eliminate warning CS4014 by explicitly discarding the Task returned by Socket.Emit by assigning it to _.
  • Update src/ElectronNET.sln to VS2022 (v17). VSCode's C# Dev Kit extension doesn't seem to like v15. Update: CICD requires VS2017 (v15) so at this point we cannot update to VS2022.

Eliminate warning CS4014 by explicitly discarding the returned Task by assigning it to `_`.
Refactor the Init and Start commands:
- Use MSBuild to get certain project properties.
- Use XML tools to read and manipulate XML files.
- Use JSON tools to read and manipulate JSON files.
- Include and deploy package-lock.json.
- Pay close attention to all paths and try to avoid making path assumptions.
- Use npm (npx) to launch electron.

Refactors `ProcessHelpers` to use `CliWrap` library for more robust command execution (argument escaping primarily).
> Note: We currently need to use an older version of the library since the bleeding edge no longer supports .NET 6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant