Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1444] transaction history redesign #1446

Merged
merged 35 commits into from
Mar 7, 2025
Merged

[#1444] transaction history redesign #1446

merged 35 commits into from
Mar 7, 2025

Conversation

LukasKorba
Copy link
Collaborator

@LukasKorba LukasKorba commented Jan 22, 2025 •
edited
Loading

Closes #1450
Closes #1448
Closes #1451
Closes #1465
Closes #1447
Closes #1449

This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see Code Review Guidelines.

Author

  • Self-review: Did you review your own code in GitHub's web interface? Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs.
  • Does the code abide by the Coding Guidelines?
  • Automated tests: Did you add appropriate automated tests for any code changes?
  • Code coverage: Did you check the code coverage report for the automated tests? While we are not looking for perfect coverage, the tool can point out potential cases that have been missed.
  • Documentation: Did you update Docs as appropiate? (E.g README.md, etc.)
  • Run the app: Did you run the app and try the changes?
  • Did you provide Screenshots of what the App looks like before and after your changes as part of the description of this PR? (only applicable to UI Changes)
  • Rebase and squash: Did you pull in the latest changes from the main branch and squash your commits before assigning a reviewer? Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit.

Reviewer

  • Checklist review: Did you go through the code with the Code Review Guidelines checklist?
  • Ad hoc review: Did you perform an ad hoc review? In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass.
  • Automated tests: Did you review the automated tests?
  • Manual tests: Did you review the manual tests?You will find manual testing guidelines under our manual testing section
  • How is Code Coverage affected by this PR? We encourage you to compare coverage before and after your changes and when possible, leave it in a better place. Learn More...
  • Documentation: Did you review Docs, README.md, LICENSE.md, and Architecture.md as appropriate?
  • Run the app: Did you run the app and try the changes? While the CI server runs the app to look for build failures or crashes, humans running the app are more likely to notice unexpected log messages, UI inconsistencies, or bad output data.

@LukasKorba LukasKorba force-pushed the 1444-Transaction-History-Redesign branch from a8a609c to 77db29a Compare February 10, 2025 13:03
@true-jared
Copy link
Contributor

@Milan-Cerovsky @HonzaR Have you guys reviewed this already?

This was referenced Feb 10, 2025
Closed
Closed
Closed
@LukasKorba LukasKorba force-pushed the 1444-Transaction-History-Redesign branch from cb63127 to 38d22ba Compare February 12, 2025 10:35
@LukasKorba
TransactionDetails screen
39344f6 
- Created and connected the new screen for the transaction details
- WIP UI inside of it
@LukasKorba
Details header implemented
edfe069
@LukasKorba
Rows of details
4750063 
- The transactions details + message rows have been implemented
@LukasKorba
Tap the whole message gesture
258cbfd
@LukasKorba
Details finished
9f2915c 
- the regular functionality for the details is done except bookmarking and adding a notes (brand new features)
@LukasKorba
Empty and home page history redesigned
00f60ba 
- The empty state redesigned
- The up to 5 transactions state has been implemented with see all option
@LukasKorba
Stack navigations for all possible paths
6454c5a 
- The code cleanup done, important for the maintenance of the new approach of transaction history
- Stack navigations for both possible path (detail from the home page directly or from the new manager screen with filters)
@LukasKorba
Time periods
15d929a 
- the list of transactions is now divided into time periods
- ability to hide balances in the transactions and the detail of a transaction
@LukasKorba
Bunch of tweaks, enhancements and fixes
67576e5 
- focus on polishing details
- bookmarking (in memory data atm)
- add a note (in memory atm)
@LukasKorba
Notes UI prepared and search memos
c4e7ef9 
- searching in memos done (SDK changes adopted)
- notes UI and flow implemented and prepared, storage is needed to enjoy full experience
@LukasKorba
UserMetadataProvider
ebcbd04 
- UserMetadataProvider prepared and connected to the Zashi's bookmarking and annotations
@LukasKorba
Texts localized
9f96833
@LukasKorba
View transaction button flow
8b9c55a 
- View transaction button is now connected to a flow for presentation of the details screen of a transaction with ability to save the address
- The screen is then dismissed to the home page (won't return back to the result screen)
@LukasKorba
Unread badge
21a1ebd
@LukasKorba
Shared states for transactions and memos
bd456ce 
- The logic around transactions have been fully refactored. The data are held by shared state only as a one source of truth
- The same idea has been done for on demand loaded memos
- The TransactionState is no longer required to be updated or copied because it doesn't carry any data and it's only an enriched version of ZcashTransaction.Overview for Zashi purposes
@LukasKorba
Optimizations
5abbb62
@LukasKorba
User metadata serialization Part I
0f087c8 
- codable structures prepared
- UM refactored
@LukasKorba
Integrations keystone update
0865f3d 
- some bugfix
- Integrations screen add keystone wallet flow added
@LukasKorba
UserMetadata entry point
1f92b35 
- UM load the data logic prepared
- Integration's seek icons have an outline now
@LukasKorba
Trimming the spaces when editing the annotation
b369232
@LukasKorba
After rebase cleanup
90cee93
@LukasKorba LukasKorba force-pushed the 1444-Transaction-History-Redesign branch from 4931c9b to 90cee93 Compare February 17, 2025 11:50
@LukasKorba
FFI' redactPCZTForSigner adopted
1f7df3c 
- Plus code cleanup after rebase
@LukasKorba
Get some ZEC flow
232be68 
- empty state on a home screen connected to a request ZEC flow
@LukasKorba
PCZT fixes
0e9e67b
@LukasKorba
UserMetadata functionality done
4918bd6 
- The UM data load/store logic done
- The UM data reset logic done
- Simple remote backup system and restore from backup implemented
HonzaR
HonzaR approved these changes Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@HonzaR HonzaR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preemptive utACK

@LukasKorba LukasKorba marked this pull request as ready for review March 4, 2025 09:25
@LukasKorba LukasKorba requested review from str4d, daira and nuttycom March 4, 2025 09:25
@LukasKorba LukasKorba added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-core-review-required Status: Core review required (e.g. for consensus compatibility or cryptographic changes) labels Mar 4, 2025
@LukasKorba
Copy link
Collaborator Author

@str4d @daira @nuttycom the cryptography is your main concern I believe and for that you don't necessarily need to review everything (UI changes, etc.) You can find it in the UserMetadataProvider folder starting with modules/Sources/Dependencies/UserMetadataProvider/UMSerialization.swift and UserMetadataEncryptionKeys in modules/Sources/Models/UserMetadataEncryptionKeys.swift

@LukasKorba LukasKorba merged commit 9c8f543 into Electric-Coin-Company:main Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HonzaR HonzaR HonzaR approved these changes

@Milan-Cerovsky Milan-Cerovsky Milan-Cerovsky approved these changes

@str4d str4d Awaiting requested review from str4d

@daira daira Awaiting requested review from daira

@nuttycom nuttycom Awaiting requested review from nuttycom

Assignees
No one assigned
Labels
S-core-review-required Status: Core review required (e.g. for consensus compatibility or cryptographic changes) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
4 participants
@LukasKorba @true-jared @HonzaR @Milan-Cerovsky