Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform: add sync (fsync) #4345

Merged
merged 3 commits into from
Feb 1, 2025
Merged

Platform: add sync (fsync) #4345

merged 3 commits into from
Feb 1, 2025

Conversation

ethanniser
Copy link
Contributor

@ethanniser ethanniser commented Jan 27, 2025

Type

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Addition of sync property to FileSystem.File representing the fsync syscall.

Related

  • Related Issue #
  • Closes #

@ethanniser ethanniser requested a review from tim-smart as a code owner January 27, 2025 00:54
Copy link

changeset-bot bot commented Jan 27, 2025

🦋 Changeset detected

Latest commit: 481908e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@effect/platform-node-shared Patch
@effect/platform Patch
@effect/platform-bun Patch
@effect/platform-node Patch
@effect/cli Patch
@effect/cluster-node Patch
@effect/cluster-workflow Patch
@effect/cluster Patch
@effect/experimental Patch
@effect/platform-browser Patch
@effect/rpc-http Patch
@effect/rpc Patch
@effect/sql-clickhouse Patch
@effect/sql-d1 Patch
@effect/sql-libsql Patch
@effect/sql-mssql Patch
@effect/sql-mysql2 Patch
@effect/sql-pg Patch
@effect/sql-sqlite-bun Patch
@effect/sql-sqlite-node Patch
@effect/sql Patch
@effect/ai Patch
@effect/ai-openai Patch
@effect/sql-sqlite-do Patch
@effect/sql-sqlite-react-native Patch
@effect/sql-sqlite-wasm Patch
@effect/cluster-browser Patch
@effect/sql-drizzle Patch
@effect/sql-kysely Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@effect-bot effect-bot changed the base branch from main to next-minor January 27, 2025 00:55
@effect-bot effect-bot force-pushed the next-minor branch 7 times, most recently from df7f007 to d425963 Compare January 29, 2025 04:26
@effect-bot effect-bot force-pushed the next-minor branch 2 times, most recently from 8faaa4b to c7af09f Compare February 1, 2025 04:03
.changeset/spicy-pumas-kneel.md Outdated Show resolved Hide resolved
@ethanniser
Copy link
Contributor Author

@tim-smart should FileSystem.FileSystem.sync exist? or should it just be on FileSystem.FileSystem.File

If it should should it take a path: string and open it internally (all other methods on FileSystem.FileSystem operate on string paths rather than raw FDs)?

@tim-smart
Copy link
Contributor

Hmm no the service method doesn't make much sense. Just keep it on the File interface.

@ethanniser ethanniser changed the base branch from next-minor to main February 1, 2025 05:01
@ethanniser ethanniser requested a review from tim-smart February 1, 2025 05:03
@tim-smart tim-smart merged commit c9175ae into Effect-TS:main Feb 1, 2025
12 checks passed
@github-actions github-actions bot mentioned this pull request Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants